Comments (13)
HI @csharpfritz @DevOpsChallengeBr
I would like to try to tackle this one :)
I have question about editing, should imported MD file overwrite existing content, or append at the bottom of the existing one?
from corewiki.
Let’s have it append.. I think that allows us to hand-edit and clean up anything above the new content.
Thanks for offering to assist!
from corewiki.
- The initial idea for this feature was:
- Put a new button on the screen anywhere on the screen
- Open a dialog box to select a file
- Read the contents of the selected file
- Fill the Content field with the content of the file uploaded
But when I look at the usability of this functionality I have a perception that it would not be the best way to deliver this functionality to users. The best way would be to add a new button in the Component toolbar (MarkDown) that is being used. Make sense? I did a search on the component repository to see how to add a New button in the toolbar but I didn't finish the search.
Which work path do you intend to follow?
from corewiki.
Hi i was thinking at trying few things out, as i'm new to razorpages.
- Upload file at server side and refresh page-model
- Upload file and use JS do append/populate Content field
Both of this with separated button on the page.
I am also willing to try expanding Component toolbar with new functionality and use it form there.
Any suggestions are welcome because at this moment i have no idea what i'm doing.
from corewiki.
In my view this feature is totally Client-side, ie should not involve anything Server-side. So if you agree, we're talking about 100% JavaScript.
Only with JavaScript will we be able to:
- Open a window to select a file (.MD)
- Read the contents of the selected file
- Inject the contents of the selected file into the markdown component
If this works! We can add see how to add a New button in the toolbar and call this JavaScript
What do you think about starting like this?@nmalocic
from corewiki.
No problem from my end!
from corewiki.
Hi @DevOpsChallengeBr @csharpfritz
I did some changes on this but i am wondering how can i create my branch and create PR so you guys can review?
Thx
from corewiki.
You can start a pull-request from your feature branch and in the comments use the"incomplete" label so that we can start discussing your work and know that its not ready for merging
from corewiki.
HI @csharpfritz @DevOpsChallengeBr i created pull request. I am not sure how to add incomplete label, but i named it (WIP) .... so that you guys know additional changes should be added.
from corewiki.
@nmalocic, this being the first approach, it worked perfectly! I noticed that the button did not accept the class of the bootstrap informed. Did you see that?
from corewiki.
hi @DevOpsChallengeBr i did notice something is off, but i also wasn't sure what to expect, i just copied classes from save button.
Did you managed to reproduce bug i repored in PR comments?
from corewiki.
@nmalocic, i put a comment on PR.
from corewiki.
Completed... thanks for the contributions!
from corewiki.
Related Issues (20)
- Refactoring to use UTF8Json
- URLFriendly method is duplicated HOT 1
- During FirstStart allow configuration of alternate Authentication Providers HOT 1
- Azure Project
- Documentation HOT 3
- Extensions: Feature LiveBlogging integration
- Handling dateformatting HOT 2
- Indentation issue while coding HOT 1
- Unable to start CoreWiki due to font awesome source error in libman.js on macOS HOT 2
- Several methods need await to be properly Async HOT 1
- Use Virus Total API
- Feature: Protected articles HOT 1
- Add option to delete user(s) HOT 3
- Need user Display names, not email addresses HOT 6
- New login thoughts
- Scan wiki content for possible PII of other users, and let those users know
- Add dependabot.com to the repo to get updates of packages HOT 1
- CoreWiki throws Errors if only dotnet core 2.2 is installed HOT 2
- Are there any plans to upgrade to ASP.NET Core 3.1?
- Live demo is down in 2023 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from corewiki.