Giter Site home page Giter Site logo

Comments (7)

ProLoser avatar ProLoser commented on August 28, 2024

Firstly, use console.log instead of
if (window.console && window.console.firebug){ console.debug(txt); } // added window.console.firebug to make this work in Opera

Still looking at the rest. Seems to happen in all browsers but chrome. I've had something like this happen before.

from anythingslider.

ProLoser avatar ProLoser commented on August 28, 2024

Okay I figured out the problem, and this will likely occur for everyone. Any links INSIDE the anythingSlider are being given a class 'focusedLink' due to the
// Fix tabing through page block of code. I'm not exactly sure how this code fixes the tabbing issue we had a while back so I just commented it out for now.

What it was doing is locating all links on the panel and binding it's own click events to them. If you put alert(page); inside the gotoPage() method you will see it is being triggered twice the first time you click on the link (passing page 1, and then page 2) and then triggered once the next time you click.

Note to Mottie: We need to change that tabbing code so people can put external links INSIDE the slider. We also need to be careful where we use return false; and instead use e.preventDefault() so people can bind more events to links. This isn't important for anythingSlider controls, but it is important for arbitrarily binded links.

surferboy: I recommend commenting out that block regarding the tabbing. I don't think it's vital to the functionality of the slider anyways.

I will leave this ticket open as I don't have a proper fix yet for the latest slider

from anythingslider.

Mottie avatar Mottie commented on August 28, 2024

Hmmm, I guess this is an issue. The slider is set up so when you tab through the links in the panels, the slider automatically switches to that panel. So the first time you click on a link, it's trying to switch to the same panel. The extended click you referred to allows the animation (which you can't see happen) to finish, then the slider changes to the panel.

I fixed it, but the problem I've run into now is any links in the cloned panel (first and last) will take the slider to those cloned panels, which shouldn't happen - they are only meant for appearance sake. I guess I could replace all links in the cloned panels with a span, but then the colors would be off...

from anythingslider.

surferboy7 avatar surferboy7 commented on August 28, 2024

Thanks for the responses! Commenting out the block regarding the tabbing works. Not sure if you guys are working on a more proper fix so I'll keep checking back. Thanks again for looking into it!

from anythingslider.

Mottie avatar Mottie commented on August 28, 2024

I have a fix... but I have a few other changes I'm including in the update, so give me an hour to update the readme, etc :P

from anythingslider.

Mottie avatar Mottie commented on August 28, 2024

Ok, try version 1.5.1 :P

from anythingslider.

surferboy7 avatar surferboy7 commented on August 28, 2024

Thanks Mottie, I'll give v 1.5.1 a try!

from anythingslider.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.