Comments (10)
Hi again guys, I can confirm that our issue is the same. Applied the modifications of the PR into a patch and everything is now working as expected! 🎉
from jss.
Hi guys, I am not pretending to make anyone fix this, just want to receive proper briefing to try fixing it myself.
Why is this PR (#1642) not good? Insufficient implementation? Missing tests?
I really like JSS, have been using it since the beginning, but now my team is evaluating to migrate to other solutions (like React TSS), because this issue completely breaks our UIs.
This is a friendly comment guys, I would really like to help or at least to understand, because this repo is not having a lot of activity and that is a risk for us (the project is really big).
@WalterWeidner @Bundas @fjpedrosa @kof
from jss.
I am interested on this. Will you open a PR?
from jss.
Hey guys, we have encountered the same problem in our project. Basically, each time the route changed, some styles didn't load properly. For example, if the table got rerendered, the last row would have broken styles. This indeed fixes the problem. I have created a PR
from jss.
Hi guys, we are currently facing the same (or at least similar) issue in a very big project. In our case, static styles get lost, probably because they are removed under the same conditions explained above. Dynamic styles continue to work because since they are linked to component's props, they get updated/added again.
We will try to debug this further, but everything seems to point to the remove function.
@Bundas @kof do you think the PR will be merged any soon? I will try to patch the dependency and see if our issue gets resolved.
Btw, we are using v10.10.0
from jss.
@ernestostifano I am glad it's working for you now. Unfortunately, the fix proposed by @WalterWeidner is not addressing the root cause. But it does the trick as a hotfix to get going.
btw for anybody wondering how to apply the patch to their project - we use https://www.npmjs.com/package/patch-package
from jss.
@Bundas oh, I understand. Is someone already working on it? Is it a priority for you? If needed, I could try to help. For us it turns to be an important issue (all the static styles get lost when it happens).
Regarding the patch, for people using modern versions of yarn, especially with PnP, we used yarn patch.
from jss.
I must add that in our case, the "root" was not being re-rendered, neither was the theme provider. It was sufficient to unmount just a portion of the app and mount it again, after unmounting/mounting some of the internal components.
from jss.
Hey guys, we have encountered the same problem in our project. Basically, each time the route changed, some styles didn't load properly. For example, if the table got rerendered, the last row would have broken styles. This indeed fixes the problem. I have created a PR
Thanks. For some reason I wasn't notified of responses to this issue.
from jss.
Could be related: #1630
from jss.
Related Issues (20)
- JSS Dynamic Rules are not removed on re-render V10.0.9
- export 'useInsertionEffect' (imported as 'useInsertionEffect') was not found in 'react' HOT 3
- Dynamic values don't work when using arrow functions HOT 7
- [cli] stdout is not a tty HOT 1
- get error msg in Micro-frontend environment: Cannot read properties of null (reading 'cssRules') HOT 3
- Support @container query HOT 9
- dynamic css issue under a certain condition since version 10.9.1-alpha.1 HOT 2
- Support @layer property HOT 2
- Docs are not able to load github's markdown files
- Bug with react-jss compilation: "Warning: [JSS] Rule is not linked. Missing sheet option "link: true"."
- TypeError: Cannot read properties of null (reading 'deleteRule')
- JSS for Preact
- React strict mode forces dynamic rules to be added twice which breaks hydration
- Code Execution Error after Applying Content Security Policy (CSP)
- Style block un-renders when any param used - since v10.0 HOT 1
- `react-jss` dynamic rules memory leak in strict mode
- StyleSheet.replaceRule does not replace media query rules
- How should i assign a counters() to the content property?
- Add specific id or data-tag to the style element injected in head?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jss.