Code Injection

[Light-Wizzard]

Code Injection

[dantti]

In themes/default/base.html you have {{cms_head}} and {{cms_foot}} that is replaced by the HTML code you fill in that option

[Light-Wizzard]

This should not be closed; its an Issue: to duplicate this issue; put code in both header and footer;
I used this for my test:
CMS Header

<style> body { background-color: lightblue; } </style>

CMS Footer

<style> body { background-color: white; } </style>

I would expect to see a white background and not a lightblue one; since the Footer in the footer will change it; but I see the same body css as is in the header, its duplicated the two.

I did find the references to {{cms_head}} and {{cms_foot}} in the base.html template; and adminsettings.cpp and root.cpp
where on line 98 I see this:
const QString cms_foot = settings.value(QStringLiteral("cms_head")); if (!cms_foot.isEmpty()) { const Grantlee::SafeString safe(cms_foot, true); c->setStash(QStringLiteral("cms_foot"), QVariant::fromValue(safe)); }
which should be this:

const QString cms_foot = settings.value(QStringLiteral("cms_foot"));

and at line 283

const QString cms_foot = settings.value(QStringLiteral("cms_head"));

same thing:

const QString cms_foot = settings.value(QStringLiteral("cms_foot"));

I need to learn how to do pushes; I will work on getting this into my github.

[dantti]

Sorry I didn't understand you had an issue, I thought you didn't understand how that worked.

[Light-Wizzard]

My bad; I was looking at the code and did not find an issue the first time; I had to debug it to find it; I knew it was an error or my misunderstanding about how the code should work; I learned how to do a pull request.