Other fantasy sports

[cwendt94]

Other fantasy sports

[cwendt94]

That’s a great idea, I really like that! I am definitely down into expanding to different fantasy sports.

Also I have been meaning to make a dev branch where all PRs can be based on. That way multiple feature and bug fixes can be merged into dev and be a test branch of all changes. This would also allow better versioning on the main package.

[cwendt94]

Interesting, that structure does look a lot simpler and will keep everything together. I will create a dev branch by the end of tonight so you can create your branch and PR off of that

[cwendt94]

@bsmiller25 I plan on adding a couple changes to the core ff_espn_api this week and pushing out a new version. Then I will start updating package name, README/Wiki, and test for the new fantasy sports PR #73

[bsmiller25]

Can you set up the dev branch soon? I've got my basketball submodule about as developed as I want it so I'm ready to submit a pull request. It's a pretty significant reorganization of the package as a whole so I think it would be a good idea for you to request changes or make changes yourself on a dev branch before merging to master. Once the structure you want is finalized the README should be updated.

The basketball part is not nearly as well built out as what you have for football but it has the league with teams and players and the players have stats. I'm mostly interested in using this for analytics so I don't plan on doing much more. At least until fantasy baseball season starts (or I find a a new use case and want more features)!

[cwendt94]

So I have been thinking a lot of how the structure would be with adding different sports. Having them all under one package could make it really tricky. A couple of things that come to mind is versioning for the different packages. If only one module updates having to update all of the packages version and then doing branching gets difficult.

My proposition and wanted to see what you think about this, is to break fb_espn_api into its own github page and PyPI package. With this I would take out the shared functionality between fantasy football and fantasy basket api and put it in its own package and repository as espn_api_util. This will make versioning and updating those packages a lot easier while still sharing the common api utils.

If you want to host the fb_espn_api on your own I could help/co work on it for the common api parts. Or if you want I could host it and have you co master contributor on it.

Thoughts?

[bsmiller25]

I think this structure is way to go:

espn-api
| -- setup.py
| -- README.md
| | espn-api
| | -- utils.py
| | -- football
| | | -- league.py
| | | -- etc
| | -- basketball
| | | -- league.py
| | | -- etc
| | -- baseball
| | | -- league.py
...

I don't think it makes versioning or branching more complicated. You wouldn't have to version the packages separately. Take a look at how numpy is structured with linalg, random, and other submodules and how their releases work. I think having separate espn-util, football, basketball, baseball, etc repos is too spread out.

[cwendt94]

develop branch has been created! https://github.com/cwendt94/ff-espn-api/tree/develop

[bsmiller25]

Pull request #73 submitted!