Giter Site home page Giter Site logo

Comments (5)

rootkea avatar rootkea commented on May 25, 2024 1

BTW, ENet provides libenet.pc so maybe we can use pkg-config within cmake instead of maintaining our own FindENet.cmake?

  1. https://stackoverflow.com/questions/29191855/what-is-the-proper-way-to-use-pkg-config-from-cmake
  2. https://cmake.org/cmake/help/latest/module/FindPkgConfig.html

from cdogs-sdl.

rootkea avatar rootkea commented on May 25, 2024 1

Moreover, I'm sorry but is there a strong a reason to maintain our own ENet in cdogs-sdl source? I mean upstream seems pretty active. Why aren't we upstreaming our ENet patches https://github.com/cxong/cdogs-sdl/commits/master/src/cdogs/enet ? It should ease the maintenance and also good for FLOSS. :)

from cdogs-sdl.

rootkea avatar rootkea commented on May 25, 2024

I did find FindENet.cmake at https://github.com/stuntrally/stuntrally/blob/master/cmake/FindENet.cmake but I'm a cmake newbie so not sure exactly which part is relevant to us...

from cdogs-sdl.

reinerh avatar reinerh commented on May 25, 2024

BTW, ENet provides libenet.pc so maybe we can use pkg-config within cmake instead of maintaining our own FindENet.cmake?

In my opinion using pkg-config to find ENet would be better than writing and maintaining a custom CMake module that searches it.

from cdogs-sdl.

cxong avatar cxong commented on May 25, 2024

It would be good to upstream any changes, but testing enet / networking is a lot of work, happy if anyone else is willing to look at it

from cdogs-sdl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.