API/ABI changes review for xxHash

[cyan4973]

API/ABI changes review for xxHash

[lvc]

XXH32_state_s and XXH64_state_s structures are now filtered from the analysis.

Thank you.

[Cyan4973]

This is a great tool @lvc , I really like it.

The compatibility warnings are related to changes in XXH??_state_s structure.

This structure should be used as an opaque incomplete type, that is, it must never be used directly.

The structure definitions are provided for situations where it's desirable to statically allocate state (typically on stack). Definition is protected by a macro XXH_STATIC_LINKING_ONLY, which is disabled by default. As the name implies, it means it's not a good fit for dynamic linking, where ABI compatibility matters. It's less of an issue when source must be re-compiled.

ABI tracker seems unaware that these symbols are not accessible by default (since they are protected by a macro which must be explicitly stated).

Not sure if that's a feature which would be possible to consider for ABI tracker. I would like it much, since that's the way most of my projects are organized : an initial "stable" section, where API and ABI stability are paramount, and an "experimental" or "static" section, protected by a similar macro, where ABI and API can change.