Comments (14)
maybe we can do something like (I'm not familiar with python sintaxis so this may not make any sense, but I think you will get the idea)
buy_limit = client.create_order(
symbol = coin,
side = 'BUY',
type = 'MARKET',
quantity = volume[coin]
)
volume[coin] = buy_limit['executedQty']
Binance API create order response docs can be found here
from binance-volatility-trading-bot.
same problem here
from binance-volatility-trading-bot.
Seems that the purchase qty - fees is not showing when trying to sell, so it results in error.
from binance-volatility-trading-bot.
I have pushed (hopefully) a stability fix for the sell function. Been testing it throughout the day and it's proven to be quite stable my side.
from binance-volatility-trading-bot.
actually by looking at the code it tries to sell the quantity listed in the volume
field of coins_bought.json
, however if I check my wallet that volume is not correct. e.g. volume states 1.357
while my Binance iOS app says I own 1.355643
. could this be the issue?
from binance-volatility-trading-bot.
actually by looking at the code it tries to sell the quantity listed in the
volume
field ofcoins_bought.json
, however if I check my wallet that volume is not correct. e.g. volume states1.357
while my Binance iOS app says I own1.355643
. could this be the issue?
Are these 0.001357 maybe your transaction fee? @dhpatel548 commented this case before
from binance-volatility-trading-bot.
Yeah - I think a change could be to fetch the actual quantity before pushing the sell order.
from binance-volatility-trading-bot.
It can't fetch balance from Binance, since you can have more on your account than bot bought. I have same problem even though I'm paying fees from BNB balance.
from binance-volatility-trading-bot.
maybe the API gives the correct value of the purchased coins. Then they could be returned at the end of buy()
from binance-volatility-trading-bot.
@phroton the API does return the actual qty bought, but seems that is not the value the script is using. It is using the calculated value when buying the coin unless I am reading the code wrong.
from binance-volatility-trading-bot.
@phroton the API does return the actual qty bought, but seems that is not the value the script is using. It is using the calculated value when buying the coin unless I am reading the code wrong.
yes, thats right - it returns the volume that has been given to buy() - but thats not the real volume
from binance-volatility-trading-bot.
@CyberPunkMetalHead this could be it ^^^
from binance-volatility-trading-bot.
Pretty sure this is fixed in latest. Closing old issues so we can start from latest commit.
from binance-volatility-trading-bot.
Using the last version, I still have this issue. Today with different pairs (FIL, XMR, SOL, IOTX, ICP, UTK, XEM, TROY...)
I can identify where in the code, it has been fixed?
from binance-volatility-trading-bot.
Related Issues (20)
- What results have you guys got using the bot?
- Ticker List HOT 1
- environment variables
- Whitelisting coins
- Telegram notifications HOT 1
- Credentials formatted incorrectly - TypeError:Exception: 'NoneType' object is not subscriptable HOT 1
- Suggestions
- AttributeError: 'dict' object has no attribute 'summary
- Your API key is either incorrect, IP blocked, or incorrect tld/permissons... HOT 4
- binance.exceptions.BinanceAPIException: APIError(code=-1003): Too much request weight used; current limit is 1200 request weight per 1 MINUTE.
- AttributeError: 'NoneType' object has no attribute 'encode'
- How does signalsample.py work?
- First handler: <tradingview_ta.main.TA_Handler object at 0x000001EB230D4BB0>
- Market vs limit sell, recommended code change
- Text notifications HOT 1
- the Trailing Stop Loss and Trailing Take Profit calculations do not make sense to me HOT 3
- Custom_List = True, Bot Not Buying Any Coins in the Ticker.txt HOT 1
- Coins Symbols not found. I have a generated list of Symbols/USDT from BINANCE US and all these coins are in the list.
- fixed version of the bot ? HOT 1
- Is this project still maintained? See description for updated bot
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from binance-volatility-trading-bot.