Giter Site home page Giter Site logo

Comments (3)

Shnatsel avatar Shnatsel commented on September 21, 2024

There is a downside to exposing packageurl::PackageUrl in the public API: every time packageurl makes a semver-breaking release, we would have to make one too. Switching to another PURL crate would also be semver-breaking.

For now we've instead exposed FromStr implementations for Purl in #381 to make it writable, but without actually transitioning to a foreign type.

from cyclonedx-rust-cargo.

alilleybrinker avatar alilleybrinker commented on September 21, 2024

Alright, seems like a good enough solution. Do you think documentation could be added to more clearly indicate this is the recommended way to interoperate with the packageurl crate?

from cyclonedx-rust-cargo.

Shnatsel avatar Shnatsel commented on September 21, 2024

There are several package URL crates in use already. I don't think it makes sense to enumerate every one in the documentation.

I'd be happy to accept a PR adding a code example that uses the FromStr impl, and a note that other package URL types should be converted to an &str first.

from cyclonedx-rust-cargo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.