Comments (3)
This is such a tough one. Certainly a polynomial option would be a great thing to offer. The problem is it is very instrument dependent. If you have a sensitivity that gradually rises, peaks and gradually falls then a polynomial is great. If you have a fairly flat response that plummets rapidly at the ends (like sprat) then polynomials can be poor. Sharp bends are terrible for polynomial too. But you are right, if the interpolation becomes unstable then the polynomial can be better. I have no proof of this, but my gut says the safest default may be very low order (linear?) interpolation function. Ultimately though my experience with every instrument is endless tinkering to really optimise and picking the right function is always a compromise, never quite ideal so there is not guaranteed best and safe answer.
from aspired.
Perhaps I should keep the interpolation method as the default but also provide a polynomial fit option. The add_sensitivity_itp(...)
should change to calling a new function add_sensitivity(..., method='interpolation')
where the method accepts 'interpolation', 'polynomial' or a callable function. Also need to add a new function add_sensitivity_poly(...)
.
from aspired.
Instead of having separate itp
or poly
, changed the sensitivity_itp
to sensitivity_func
that can hold either an interpolated function or a polynomial function. The default setting is still using interpolation because it is much more stable, I do not recommend using polynomial in an automated reduction unless the sensitivity is known to be well described by a low order polynomial.
from aspired.
Related Issues (20)
- Header not handled when provided manually
- Provide an example of a double-gaussian extraction with a user-provided LSF.
- Add to this list
- Confusing and user-unfriendly syntax for getting standard continuum
- Asymmetrical extraction profile gives wrong normalisation HOT 1
- Unclear how `add_filelist()` and hdu number work HOT 1
- Provide a very high level function that carries out all the 2D operation
- Optional experimental aperture correction based on the fitted Gaussian profile HOT 1
- `OneDSpec.add_spec()` should accept a FITS header
- Retain pre-rectification trace info
- Two different definitions of saxis HOT 1
- v0.4.9 Logging error for science and standard airmass in apply_atmospheric_extinction_correction() HOT 3
- issues with loading standard stars HOT 1
- change the sensitivity function to be always at airmass 1.0
- Default cosmic ray rejection too aggressive HOT 1
- inspect_extracted_spectrum() zero-size array to reduction operation fmin which has no identity HOT 9
- `arc_spec` was exported with a HDU header name of `flux`
- Header keyword collision: `CDELT1` and `CD1_1` etc.
- `set_properties()` in `TwoDSpec()` should scan the header HOT 1
- Difficult to negvigate the Readthedocs spectral_reduction
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aspired.