Giter Site home page Giter Site logo

Comments (7)

CZEMacLeod avatar CZEMacLeod commented on May 25, 2024 1

It has been a while since I did webforms development (I mainly use/maintain MVC and Razor these days).
Are there any other types that should be included? I seem to remember master pages (.master?).
I believe these should be recursive so they include at any depth of folder, not just the root so probably something like

  <ItemGroup>
    <Content Include="**\*.asax" />
    <Content Include="**\*.ascx" />
    <Content Include="**\*.asmx" />
    <Content Include="**\*.aspx" />
    <Content Include="**\*.master" />
  </ItemGroup>

I'll look at adding these as default includes, perhaps behind a flag so that they can be disabled if required.

from msbuild.sdk.systemweb.

CZEMacLeod avatar CZEMacLeod commented on May 25, 2024 1

@chucker .resx and web.config files were already handled. And .axd files do not actually exist - the URLs are just routed to a handler class by IIS.

from msbuild.sdk.systemweb.

chucker avatar chucker commented on May 25, 2024

Good point — .master, too. And yes, it should be recursive (technically, the rules are more complex; e.g. App_Code should not contain markup).

from msbuild.sdk.systemweb.

klinki avatar klinki commented on May 25, 2024

I believe .ashx should be also included

from msbuild.sdk.systemweb.

chucker avatar chucker commented on May 25, 2024

Possibly also resx, axd, config.

from msbuild.sdk.systemweb.

mcnallys avatar mcnallys commented on May 25, 2024

@CZEMacLeod Thanks for the great work on this project. I updated to this version and noticed an issue after performing a publish.

In my project I end up with "bin\Release\Publish" as the output folder, however if turn on EnableWebFormsDefaultItems, once I publish it see's that published folder as content. Then each publish adds more content upon itself and eventually errors.

I have worked around this in some of my other globs by adding Exclude="$(DefaultItemExcludes)".

I recommend changing from:

<Content Include="**\*.asax" />
<Content Include="**\*.ascx" />
<Content Include="**\*.ashx" />
<Content Include="**\*.asmx" />
<Content Include="**\*.aspx" />
<Content Include="**\*.master" />

to

<Content Include="**\*.asax" Exclude="$(DefaultItemExcludes)" />
<Content Include="**\*.ascx" Exclude="$(DefaultItemExcludes)" />
<Content Include="**\*.ashx" Exclude="$(DefaultItemExcludes)" />
<Content Include="**\*.asmx" Exclude="$(DefaultItemExcludes)" />
<Content Include="**\*.aspx" Exclude="$(DefaultItemExcludes)" />
<Content Include="**\*.master" Exclude="$(DefaultItemExcludes)" />

from msbuild.sdk.systemweb.

CZEMacLeod avatar CZEMacLeod commented on May 25, 2024

@mcnallys I've created a new issue #25 for this problem.

from msbuild.sdk.systemweb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.