Giter Site home page Giter Site logo

Comments (12)

celsomtrindade avatar celsomtrindade commented on June 15, 2024 1

I think it's just a problem with his uglify proccess. I did my own from his original source code using grunt uglify proccess and it's working just fine. In case anyone wants the file, this is it.

Because of the extension limit here, I've renamed the file to a .txt extension, you just need to reverse it to .min.js and it'll work.

ngScroll.TXT

from ngsmoothscroll.

tiagodocouto avatar tiagodocouto commented on June 15, 2024

same problem here!
version 1.7.1 its ok!

from ngsmoothscroll.

wizjack avatar wizjack commented on June 15, 2024

Do you mean to say it's not working in 2.0.0 and working in 1.7.1. In that case I may have to revert.

from ngsmoothscroll.

tiagodocouto avatar tiagodocouto commented on June 15, 2024

yes, I can confirm that

from ngsmoothscroll.

celsomtrindade avatar celsomtrindade commented on June 15, 2024

+1 Same here.

Note: Only tested with the function scroll-to="my-id" when refering to an element ID and a simple smooth-scroll to automatic scroll to the element when rendering.

No scroll. Sometimes it scrolls just a pixel. Tested with 1.7.4 and had same results.
Only first version working.

from ngsmoothscroll.

alexkb avatar alexkb commented on June 15, 2024

I couldn't get any scrolling occurring (nor did I see any errors) with the minified version, but when I switched to the unminified it started working fine.

from ngsmoothscroll.

wizjack avatar wizjack commented on June 15, 2024

Naaa, tried the older version still not working. Does it not work with ui views in place and view not being a single html page, just a thought.

from ngsmoothscroll.

celsomtrindade avatar celsomtrindade commented on June 15, 2024

@alexkb same here, version 2.0 works only with unminified version. .min.js doesn't work.

from ngsmoothscroll.

Matoyak avatar Matoyak commented on June 15, 2024

This seems to be the same issue as #57 . Something got borked in the minification process. (I notice there's a pull request for a fixed minified version which references #59 , which is also apparently the same issue as #57 and this one).

from ngsmoothscroll.

wizjack avatar wizjack commented on June 15, 2024

I don't have minification problems. I'm using gulp for minifications. I think it's more related to the content area that needs to scroll, in my case it seems there's isn't much area to scroll. I think I can close this.

from ngsmoothscroll.

celsomtrindade avatar celsomtrindade commented on June 15, 2024

@wizjack The problem is when using the min file provided in the github, if you do yours (like i did) it should work.

from ngsmoothscroll.

wizjack avatar wizjack commented on June 15, 2024

@celsomtrindade mine working fine. :)
On second thoughts I feel documentation can be enhanced by adding a demo/example. Closing this. Thank you all.

from ngsmoothscroll.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.