Giter Site home page Giter Site logo

Comments (3)

mbostock avatar mbostock commented on May 7, 2024

I tested this in Firefox, and this is a fairly basic feature of SVG. Are you using an old version of Firefox? Are you not setting with the width and height of your SVG explicitly (which is required)? Do you have an example on bl.ocks.org or similar that demonstrates the issue? What is the resulting computed extent that you are seeing?

from d3-brush.

ldegen avatar ldegen commented on May 7, 2024

my firefox reports version 45.2.0.

I assume by "explicit" you mean in pixels rather than percentage?
Right now, width and height of the SVG are set to "100%" via CSS rule.
This may in fact be the problem, I haven't thought of that, thanks.

I will have another look during the weekend and report back.

from d3-brush.

mbostock avatar mbostock commented on May 7, 2024

Right. You can set width and height CSS properties to control how much space the SVG element takes up on the page, but even if you do that, you also need to set the width and height attributes on the SVG element to fix the coordinate system. (Alternatively you can use the viewBox attribute, but that isnโ€™t supported by the default implementation of brush.extent.)

Iโ€™ll change the documentation to note that the default implementation requires these attributes. As you discovered you can also set the extent explicitly or substitute a different implementation.

from d3-brush.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.