Giter Site home page Giter Site logo

Comments (3)

Fil avatar Fil commented on May 16, 2024 1

geoRectangularPolyconicRaw with no phi0 returns NaNs because geoRectangularPolyconicRaw is a function (of phi0) that returns a raw projection. So that's expected.

The second part of your comment seems indeed to point to something missing in the way we compute the shifting of the lobes, by assuming that the equator is of constant scale (if I'm reading correctly
https://github.com/d3/d3-geo-projection/blob/master/src/interrupted/index.js#L74 )

(As phi0 is the "true scale" parallel of that projection (expressed in radians), when you set it to 0 you effectively get a true scale equator which explains why the lobes are correctly contiguous in this case.)

from d3-geo-projection.

mxfh avatar mxfh commented on May 16, 2024

I see that the lobe origin is scaled at the non-true scale for non-zero phi0, but most curious about why it seems to not effect lobe count = 2 ? Because the scaled lobe offset is cancelled out by the scale change within the lobe at equator?

This seems to affect all projections where the raw function is a function of a parallel/parallels or with a non-true scaled equator.

See Armadillo here:
compatibility-of-georectangularpolyconicraw-with-geoin

from d3-geo-projection.

Fil avatar Fil commented on May 16, 2024

I just commited a change that addresses the issue. It's not complete (no inverse, no tests…), but it's a start :)

You can test the build at https://observablehq.com/d/bde6f23d798d4f72 (it uses https://files-6p35z2y9v.now.sh/d3-geo-projection.js )

I've also removed the meaningless geoRectangularPolyconicRaw test.

See branch https://github.com/d3/d3-geo-projection/tree/issue178

from d3-geo-projection.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.