Giter Site home page Giter Site logo

Comments (3)

mbostock avatar mbostock commented on August 17, 2024

This might require using a different trick to make the step curve symmetric:

var t = x > this._x ? this._t : 1 - this._t;

Perhaps something like curve.reverse() which returns a reverse curve to be used as the area’s baseline. If undefined, the curve is used.

from d3-shape.

mbostock avatar mbostock commented on August 17, 2024

I’ve simplified the step curve in e3b1b0a, but there’s another issue that makes this difficult to implement: if the curve processes partially-defined points, it must use context.moveTo to render a discontinuity for a line, and likewise it must generate discontiguous area segments for an area.

It’s probably not possible for the step curve to produce discontiguous area segments internally; that’s primarily the responsibility of the area shape, which buffers the input coordinates so that it can pass the reversed xy coordinates of the baseline to the curve.

from d3-shape.

mbostock avatar mbostock commented on August 17, 2024

I think you could maybe implement this by first detecting whether x or y was NaN inside the area and line shapes, and treating that as similar to the defined accessor returning falsey. Then, the shape would call curve.lineEnd (or maybe curve.point again?), passing in the partially-defined x and y, before terminating the line segment. That would give the curve the opportunity to draw the terminating tail to a partially-defined value, while keeping the responsibility to generate discontiguous line and area segments with the shape. You’d need to do something similar on curve.lineStart, passing in the last (possibly) partially-defined x and y before the first point in the new segment; this way the stepBefore curve could render a preceding horizontal line before the first defined value.

from d3-shape.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.