Giter Site home page Giter Site logo

Comments (3)

ricokahler avatar ricokahler commented on May 31, 2024 1

Would it make sense to add a new gatsby package for each scenario we want to test?

I think so, creating a publishable starter for each scenario (and put each starting in /packages) seems like the right thing to do but it also sounds like a lot of work to maintain if the number of scenarios or number of features in a scenario grows too much.

So given that, I think it makes sense to add (and potentially publish) one simple and bare-bones package to this repo for now: packages/gatsby-starter-ts (this name is also available on npm and it's on-brand with gatsby-plugin-ts!)

It will be a modified version of gatsby-starter-default that will include gatsby-plugin-ts. This package will have two purposes:

  1. be an actual starter that people can use
  2. be part of our CI where it building successfully is a required status check before merging PRs etc

This + the tests we added in #42 should give us pretty significant coverage. We could even add tools like dependabot that will automatically open PRs for upgrades to packages. If we run our tests and run our builds, we should have no problem merging in dependabot PRs.


In respect to #39 , like you suggested, I think it makes sense to create another starter that includes working with the apollo client and codegen but that effort can come after we create gatsby-starter-ts.

from gatsby-typescript.

d4rekanguok avatar d4rekanguok commented on May 31, 2024

That's a great idea!! Would it make sense to add a new gatsby package for each scenario we want to test? i.e codebase with mixed ts/js, codebase with apollo client (#39), codebase with gatsby-node.ts etc.

Also, I am very impressed with the professionalism shown in the way you communicate & your code — would you accept to be a collaborator to this project? It'll be easier to work on the tests and also #39

from gatsby-typescript.

d4rekanguok avatar d4rekanguok commented on May 31, 2024

Agreed, I also found this helpful article to publish starter from within a workspace with github actions:
https://johno.com/publishing-gatsby-starters-from-monorepo

from gatsby-typescript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.