Giter Site home page Giter Site logo

Comments (5)

daanx avatar daanx commented on August 26, 2024 1

Thanks for the feedback -- so bad bench.sh was missing! Just added it and will test with it.
Otherwise:

  • hoard: hmm, what does that error mean? perhaps running with sudo fixes it? I think we can work around it by not installing hoard, just compiling it. I'll look into it.
  • supermalloc: I'll try to run it with warnings as warnings . I guess this is new behaviour for GCC 9?
  • rpmalloc: I think we need to disable -Werror,-Watomic-implicit-seq-cst
    I'll try to fix it and perhaps you can try again.
    Thanks!!

from mimalloc-bench.

SteveBronder avatar SteveBronder commented on August 26, 2024

Thanks for including it! I'll downgrade to gcc 8 and try again.

hoard: hmm, what does that error mean? perhaps running with sudo fixes it? I think we can work around it by not installing hoard, just compiling it. I'll look into it.

I've gotten hoard to compile before on this machine, I think it's just that calling make plain doesn't call the correct config for hoard. I can give it another go later this week.

https://github.com/emeryberger/Hoard/blob/master/src/GNUmakefile#L39

For the other two I've never touched them so I have no clue

from mimalloc-bench.

daanx avatar daanx commented on August 26, 2024

I just pushed an update to the build scripts that build all external dependencies in an extern folder local to mimalloc-bench. Also, I think i fixed the supermalloc and hoard builds.

from mimalloc-bench.

SteveBronder avatar SteveBronder commented on August 26, 2024

Nice ty! I was also seeing an error in rpmalloc

[1/40] CC test/thread.c
FAILED: build/ninja/linux/debug/b'x86_64'/test-57ec084/thread-35aa063.o 
clang -MMD -MT 'build/ninja/linux/debug/b'\''x86_64'\''/test-57ec084/thread-35aa063.o' -MF 'build/ninja/linux/debug/b'\''x86_64'\''/test-57ec084/thread-35aa063.o'.d -I. -Irpmalloc -Itest -DRPMALLOC_COMPILE=1 -funit-at-a-time -fstrict-aliasing -fno-math-errno -ffinite-math-only -funsafe-math-optimizations -fno-trapping-math -ffast-math -D_GNU_SOURCE=1 -W -Werror -pedantic -Wall -Weverything -Wno-padded -Wno-documentation-unknown-command -std=c11 -Werror -Watomic-implicit-seq-cst  -DBUILD_DEBUG=1 -g -DENABLE_ASSERTS=1 -DENABLE_STATISTICS=1 -c test/thread.c -o 'build/ninja/linux/debug/b'\''x86_64'\''/test-57ec084/thread-35aa063.o'
test/thread.c:95:2: error: implicit use of sequentially-consistent atomic may incur stronger memory barriers than necessary [-Werror,-Watomic-implicit-seq-cst]
        __sync_synchronize();
        ^~~~~~~~~~~~~~~~~~
test/thread.c:104:2: error: implicit use of sequentially-consistent atomic may incur stronger memory barriers than necessary [-Werror,-Watomic-implicit-seq-cst]
        __sync_synchronize();
        ^~~~~~~~~~~~~~~~~~
2 errors generated.
[2/40] CC test/thread.c

But that's an error in their stuff and they have a fix for it on their develop branch

mjansson/rpmalloc#86

You should be able to fix it by changing the build script to use

git clone https://github.com/mjansson/rpmalloc/issues/86 -b develop

Seems like after that all the benchmarks are running tho!

from mimalloc-bench.

SteveBronder avatar SteveBronder commented on August 26, 2024

This puppy purrs though!

Below is a graph of the tests on my machine with (Ryzen 7 CPU)

image

Some of those are within a pretty reasonable margin of error. tbb is v v v slow which I'm surprised by

from mimalloc-bench.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.