Make record names unique

[dabcoder]

Make record names unique

[dabcoder]

Would you have an example of that, as in, how would it work for, say, Quote?

[ksallberg]

Lets say we want to read the 'companyName' field of the Stats record, like this (from branch bug/no-lookup):

diff --git a/Tests/Main.hs b/Tests/Main.hs
index 9996609..0c185f4 100644
--- a/Tests/Main.hs
+++ b/Tests/Main.hs
@@ -95,3 +81,15 @@ testMultiBatch1 = TestCase
 testMultiBatch2 = TestCase
   (do result <- getBatch ["dps", "fb"] [OHLCQuery, CompanyQuery]
       assertBool "" (result /= Nothing))
+
+
+-- fail
+testCorrectCompanyName = TestCase
+   (do result <- getBatchCompany "aapl" [StatsQuery, NewsQuery, CompanyQuery]
+       assertEqual "" (pickCompanyName result) "Apple Inc.")
+
+pickCompanyName :: Maybe Batch -> String
+pickCompanyName (Just (Batch {stats = st})) = pickCompanyName' st
+
+pickCompanyName' :: Maybe Stats -> String
+pickCompanyName' (Just (Stats {companyName = cname})) = cname

We can't do this, since 'companyName' is not unique:

/Users/kristiansallberg/Documents/stocks/Tests/Main.hs:95:32: error:
    Ambiguous occurrence ‘companyName’
    It could refer to either the field ‘companyName’,
                             imported from ‘Net.Stocks’ at Tests/Main.hs:5:1-17
                          or the field ‘companyName’,
                             imported from ‘Net.Stocks’ at Tests/Main.hs:5:1-17
                          or the field ‘companyName’,
                             imported from ‘Net.Stocks’ at Tests/Main.hs:5:1-17
   |
95 | pickCompanyName' (Just (Stats {companyName = cname})) = cname
   |

So the way I propose to fix this, is to put the data structure definitions in separate modules, so that they can be uniquely accessed. If you don't have some better solution :-)

edit Actually, it works fine if '{-# LANGUAGE DuplicateRecordFields #-}' is added to the files using our library. But it kind of sucks to have to use language extensions just to use this lib

[ksallberg]

Please see this 693aec3 for what it would look like with my proposal (for Stats). I guess another solution would be to make sure no record fields are duplicate, like "statusCompanyName" in Status

[dabcoder]

I see, thanks for the detailed explanation.
We can probably go ahead with your proposal, I don't have any other suggestions at this point, thanks for looking into it!

[ksallberg]

Fixed by factoring out data types to their own haskell modules