newlines in output files?

[waynenilsen]

newlines in output files?

[daboross]

The behavior is defined in https://github.com/daboross/fern-rs/blob/master/src/loggers.rs#L109.

However, there doesn't currently seem to be a way to get the system line separator defined in the rust standard library. Do you think a way to set the line separator in the logger configuration would suffice for this (defaulting to \n)?

[waynenilsen]

I added an rfc so we'll see if they want to add that functionality or not. I think it is pretty low hanging fruit for the 1.0 release.

[SimonSapin]

This doesn’t have to be in the standard library, you can use cfg attributes for conditional compilation:

#[cfg(windows)]
const NEWLINE: &'static str = "\r\n";

#[cfg(not(windows))]
const NEWLINE: &'static str = "\n";

[waynenilsen]

It doesn't have to be but it certainly could be. I just wanted to give the rust team a chance to add it as a feature if they want to.

[daboross]

Since there hasn't been that much discussion on the rust issue, I'm just going to implement a configurable value for now.

It seems better (to me at least) to not implicitly change behavior depending on platform, and instead allow the user of the library to explicitly choose what newline separator they want (if it isn't \n).

[daboross]

Since fern 0.3.5, setting a custom line separator has been supported. In fern 0.4.0, this can be done with Output::file.

I'm going to close now, as I think it's reasonable to let the user decide if they need platform-specific line endings. I'd rather not have fern decide this for the user, but if rust ever adds the line-ending constant mentioned above, I would be glad to re-visit this!