Project scpecific rg-command-line-flags

[muffinmad]

Project scpecific rg-command-line-flags

[dajva]

Thanks, I'll implement this for 1.5.0

[dajva]

Hi,
That seems like a job for projectile itself, i.e. handling project local variables in general. I don't use projectile myself so I am not familiar how a project is defined but if it's just a top level dir emacs builtin dir local variables may suffice for this.
See https://www.gnu.org/software/emacs/manual/html_node/emacs/Directory-Variables.html

[muffinmad]

I created function which returns some commandline params for rg depending on current project. I just can't figure out how to make my function called by rg-build-template. Is it possible that rg-build-template will call custom function alongside with rg-command-line-flags variable?

Thanks!

[dajva]

I am not very keen on adding more complexity to the configuration, i.e. adding a hook or additional setting. And I really think that it's something that should be handled by projectile or by other means within emacs.

Now, there is one change that I think would make sense in this area that I am willing to accept. We could add the possibility to make rg-command-line-flags be a function that returns a list of flags instead of a hard coded list. In essence extend the setting to be either a list or a function. Should be a pretty small change. Please make a pr if you think this makes sense for your use case.

Thanks for your suggestion.

[muffinmad]

This solution is perfect and is exactly what i was looking for.
I will try to make PR but it may take some time because of my almost zero elisp knowledge.

[dajva]

Great. This is small enough to work on if you want to expand your elisp knowledge a bit. If you don't get it done I can probably fix it for next release. But it will take some time to land on master since I have my hands full elsewhere currently.

[dajva]

Are you still interested in this feature?

[muffinmad]

I've tried to make PR and stuck at making the custom variable rg-command-line-flags to be list or function.

For now rg-command-line-flags contains ignore files for all my projects. It's works well as there are no conflicts in those ignore files.

So for now i don't actually need this feature. But it would be nice to have it some day.