In 2.0.4 the custom encoding fails to correctly encode on hash-map

[wthidden]

In 2.0.4 the custom encoding fails to correctly encode on hash-map

[wthidden]

Further investigation has lead to a simpler case where encoding fails to encode correctly.
(custom/encode '('one 'two)) -> "[["/","/"],["/","/"]]"

as the json encoded string. I suspect symbol handling somewhere is the issue.

[dakrone]

Yea, I suspect the symbol handling is also to blame. I'll take a look at this.

[wthidden]

I think I know the issue after looking at the code.

The code assumes that the symbol will have been interned. In my case that
is not true, so resolve returns nil.

I think testing for symbol internment will be what is needed to resolve the
issue.

(William Hidden) https://sites.google.com/site/hiddenhome/

On Wed, Jan 11, 2012 at 12:52 PM, Lee <
[email protected]

wrote:

Yea, I suspect the symbol handling is also to blame. I'll take a look at
this.

---

Reply to this email directly or view it on GitHub:
#13 (comment)

[wthidden]

Lee,

Here's how I patched encode-symbol to get what I needed. Not sure if it
complies with what you were looking for:

diff --git a/src/cheshire/custom.clj b/src/cheshire/custom.clj
index 399ca63..cccbad7 100644
--- a/src/cheshire/custom.clj
+++ b/src/cheshire/custom.clj
@@ -126,9 +126,11 @@
"Encode a clojure symbol to the json generator. Symbols will be encoded
as
/"
[^clojure.lang.Symbol s ^JsonGenerator jg]

• (.writeString jg (str (:ns (meta (resolve s)))

•                    "/"
  

•                    (:name (meta (resolve s))))))
  

• (if (resolve s)
• (.writeString jg (str (:ns (meta (resolve s)))

•                      "/"
  

•                      (:name (meta (resolve s)))))
  

• (.writeString jg (name s))))

;; extended implementations for clojure datastructures
(extend nil

(William Hidden) https://sites.google.com/site/hiddenhome/

On Wed, Jan 11, 2012 at 2:16 PM, William Hidden [email protected]:

I think I know the issue after looking at the code.

The code assumes that the symbol will have been interned. In my case that
is not true, so resolve returns nil.

I think testing for symbol internment will be what is needed to resolve
the issue.

(William Hidden) https://sites.google.com/site/hiddenhome/

On Wed, Jan 11, 2012 at 12:52 PM, Lee <
[email protected]

wrote:

Yea, I suspect the symbol handling is also to blame. I'll take a look at
this.

---

Reply to this email directly or view it on GitHub:
#13 (comment)

[dakrone]

I just pushed a fix for this in eaee529, can you give it a shot and see if it works for all your use cases?

[wthidden]

Yes... works for me, thanks.

(William Hidden) https://sites.google.com/site/hiddenhome/

On Wed, Jan 11, 2012 at 6:21 PM, Lee <
[email protected]

wrote:

I just pushed a fix for this in eaee529, can you give it a shot and see if
it works for all your use cases?

---

Reply to this email directly or view it on GitHub:
#13 (comment)

[dakrone]

Cool, I'll push a new version out with this fix.

[dakrone]

Fixed in 2.0.5

[wthidden]

Thank you for putting together the Cheshire library it is exactly what I
needed!

(William Hidden) https://sites.google.com/site/hiddenhome/

On Wed, Jan 11, 2012 at 6:34 PM, Lee <
[email protected]

wrote:

Fixed in 2.0.5

---

Reply to this email directly or view it on GitHub:
#13 (comment)