Host validation required in cadre.ssh()

[dalethestirling]

Host validation required in cadre.ssh()

[dwurf]

Two thoughts:

1. Try to resolve hostname via gethostbyname / find in ssh config, or
2. Don't do any validation, just detect and report the error case via sensible exceptions (EAFP)

I like 2 because it opens the door for constructs like ssh('proxy').ssh('prod').git.pull() (where prod is not known to the originating host)

[dalethestirling]

I do think that execution of nested ssh as in option 2 is important especially when you get into cases as you suggest, but this gets to the question that we talked about in issue #1

If we have the situation of the construct:

    ssh('proxy').ssh('prod').git.pull()

Where should we be resolving the sh module command lookups? and how far do we drill as the above example is across 2 hosts.

This is something that I am not sure how to handle yet?

[dalethestirling]

Implementation going forward will use option 2 where we take the EAFP approach and work on the exceptions rather than complex host validations that will lead to false positives.

This also allows cadre to maintain its alignment with sh

I have opened issue #3 to capture thoughts on how exceptions should be dealt with.