generate lenses automatically

[sboosali]

generate lenses automatically

[dan-t]

Hi Sam,

I've already implemented it. I'd be happy to merge it. as well as bump cabal to 1.22.4.

Ok. :) Greetings, Daniel

[sboosali]

great!

[sboosali]

http://packdeps.haskellers.com/reverse/cabal-lenses

since you've authored both reverse dependencies (i.e. breakages can be handled), would you like me to make it build without warnings under -Wall on ghc 7.10.1? e.g.

lib/CabalLenses/Version.hs:12:1:
Warning:The import of Control.Applicativeis redundant except perhaps to import instances fromControl.Applicative 

it would of course break the build on earlier compiler versions.

either way, I think it needs a major version bump for the updated Cabal version.

[dan-t]

Hi Sam,

On Thu, Oct 15, 2015 at 07:53:06AM -0700, Sam Boosalis wrote:

since you've authored both reverse dependencies (i.e. breakages can be
handled), would you like me to make it build without warnings under -Wall on
ghc 7.10.1? e.g.

Just -W is enough.

lib/CabalLenses/Version.hs:12:1:
Warning:The import of Control.Applicativeis redundant except perhaps to import instances fromControl.Applicative

it would of course break the build on earlier compiler versions.

You can use:

#if GLASGOW_HASKELL < 710
import Control.Applicative ((<$>))
#endif

either way, I think it needs a major version bump for the updated Cabal
version.

Why that?

Greetings,
Daniel

[sboosali]

1. cool, haven't used CPP before. that seems better.

also to avoid shadowing warnings, I hoisted some helper functions to the top
level, but didn't export them. (I'll put all this in the commit message, where it's in context). I've been
bitten by name shadowing before (after a re-factoring), so I think it's a
good idea anyway.

also, added an explicit PatternGuards extension to silence another warning.

1. oops, I misread cabal's latest version (1.22.4) as 1.24

On Thu, Oct 15, 2015 at 11:28 AM, Daniel Trstenjak <[email protected]

wrote:

Hi Sam,

On Thu, Oct 15, 2015 at 07:53:06AM -0700, Sam Boosalis wrote:

since you've authored both reverse dependencies (i.e. breakages can be
handled), would you like me to make it build without warnings under
-Wall on
ghc 7.10.1? e.g.

Just -W is enough.

lib/CabalLenses/Version.hs:12:1:
Warning:The import of Control.Applicativeis redundant except perhaps to
import instances fromControl.Applicative

it would of course break the build on earlier compiler versions.

You can use:

#if GLASGOW_HASKELL < 710
import Control.Applicative ((<$>))
#endif

either way, I think it needs a major version bump for the updated Cabal
version.

Why that?

Greetings,
Daniel

—
Reply to this email directly or view it on GitHub
#4 (comment).

(this message was composed with dictation: charitably interpret typos)Sam
Boosalis