All the dark themes use the same colors

[dandavison]

All the dark themes use the same colors

[dandavison]

This is actually correct behavior: --show-colors is showing the background colors that delta uses to highlight added and removed content (plus and minus lines, and emphasized within-line sections). In contrast, the "theme" determines the foreground colors that are used for language syntax highlighting (by syntect). So in your examples, you're not changing the background colors. (You could change them with something like delta --show-colors --minus-color="#C3A3F3")

You raise a good point: I think maybe I should rename that option --show-background-colors or something, instead of simply --show-colors. And also perhaps raise an error if a combination of options is passed that doesn't make sense together.

To look at the differences between themes, you can use delta --compare-themes (you can pipe your own git output into that command, or if you don't it will use some default diff output.)

[dandavison]

I've changed the option name and improved the help text (see #32). Thanks for prompting.

[deanhouseholder]

Cool. 🙂

…

On Wed, Oct 16, 2019 at 11:02 PM Dan Davison ***@***.***> wrote: I've changed the option name and improved the help text (see #32 <#32>). Thanks for prompting. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#31?email_source=notifications&email_token=AAFPIENHRD4VUHV5PR5MGELQO7WWNA5CNFSM4JBQ7WT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBOZDOA#issuecomment-543003064>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFPIEPBFUWXPUG5SHCXNVLQO7WWNANCNFSM4JBQ7WTQ> .