Comments (7)
This is fixed in master, including handling of unified diff directory comparisons, thanks to work by @m-lima: #56.
from delta.
Thanks, absolutely agree this makes sense. (Indeed it makes me uncomfortable that the package name is git-delta
seeing as I would like it to support standard unified diff when not embedded in git output.)
Incidentally, this would make a good issue for anyone looking for a smallish Rust exercise.
from delta.
I'm pretty new to Rust and I would like to start contributing to OSS. Do you mind if I take a stab at this?
from delta.
@m-lima That would be great, thanks very much! Feel free to discuss further / ask me any questions.
from delta.
Thanks @dandavison, I will get started on it
@fdcds I wasn't able to really replicate the problem on version 0.0.14
I tried it on Ubuntu and Catalina.
However, I did notice an assumption of a/<file_name_1> and b/<file_name_2> from git --diff. But that the most of a weird behavior I got
from delta.
I understood the situation now. It is more accentuated when comparing directories, and you have multiple file headers.
Pushing a commit to assess that as well, by adding a new state that captures diff -u
or diff -U
from delta.
Thanks a lot to both of you!
from delta.
Related Issues (20)
- π Colours different on different systems. HOT 1
- π Delta as `diffFilter` breaks keyboard input with `git add -p` in Git CMD HOT 12
- π delta fails to build with enabled `lto` HOT 1
- π Incorrect use of bright-black background with native less pager on Windows
- π New binary release please! HOT 2
- Regression in highlighting from #1037 HOT 5
- π test env::tests::test_env_parsing_with_pager_set_to_bat ... FAILED HOT 4
- π Always using light theme on dark background HOT 9
- π 0.17.0 seems much slower then 0.16.5 HOT 11
- π --navigate n/N jumps to next/prev hunk, not file?
- RUSTSEC-2024-0320: yaml-rust is unmaintained.
- π Incorrect syntax-highlight with comment tag "#"
- π [Docs] Show the default config values
- π Extra newline before diffs
- π Empty diff for proc files
- [Feature Request] Show percentage of how far the entire diff has been read
- `git grep -l` replaces first `-` with a `:`
- Not working in Ubuntu 22.04 as intendedπ
- π inserted/deleted blank lines are sometimes hard to see
- Specify light and dark themes simultaneously, and auto-switch based on system appearance
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from delta.