Giter Site home page Giter Site logo

Comments (6)

hockeybuggy avatar hockeybuggy commented on May 24, 2024 3

Based on @benkimpel's thoughts related to the padding being unchanged after dropping the .todos it seems like this would be good thing to have be opt in (this would also avoid a breaking change [if we considering rules failing to be breaking]).

Seems like it.todo would be the only method that this would really make sense for (.each, .only, .skip don't seem to make sense to have padding variations).

I think my stance is that if someone would like to contribute this, I would be in favour of including it.

from eslint-plugin-jest-formatting.

aymericbouzy avatar aymericbouzy commented on May 24, 2024 1

As I've said in #85 I've never written an ESlint rule before, but I'm willing to try 👍

from eslint-plugin-jest-formatting.

benkimpel avatar benkimpel commented on May 24, 2024

@aymericbouzy Interesting rule request! I hadn't considered that before.

My quick reaction is that one might more often want their it.todo padding to match their it padding since then they could just remove the .todo, implement the test, and have valid padding at that point, but I do recognize that one form is typically multiline while the other is not and I can appreciate the aesthetic difference.

Could be an interesting rule to implement since, iirc, we don't look past the first token right now.

Disclaimer I'm just a contributor. :)

@dangreenisrael @hockeybuggy thoughts?

from eslint-plugin-jest-formatting.

dangreenisrael avatar dangreenisrael commented on May 24, 2024

I think having it as an option would be nice, but I won't have any time for it for at least the next 2 months.

@hockeybuggy Thoughts?

from eslint-plugin-jest-formatting.

dangreenisrael avatar dangreenisrael commented on May 24, 2024

@aymericbouzy No time like the present to learn something new. I learned with this course. https://frontendmasters.com/courses/linting-asts/

from eslint-plugin-jest-formatting.

dangreenisrael avatar dangreenisrael commented on May 24, 2024

Hey, I'm closing this due to a seeming lack of interest. If it can get 5 +1s I'll reopen it.

from eslint-plugin-jest-formatting.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.