Comments (6)
Based on @benkimpel's thoughts related to the padding being unchanged after dropping the .todo
s it seems like this would be good thing to have be opt in (this would also avoid a breaking change [if we considering rules failing to be breaking]).
Seems like it.todo
would be the only method that this would really make sense for (.each
, .only
, .skip
don't seem to make sense to have padding variations).
I think my stance is that if someone would like to contribute this, I would be in favour of including it.
from eslint-plugin-jest-formatting.
As I've said in #85 I've never written an ESlint rule before, but I'm willing to try
from eslint-plugin-jest-formatting.
@aymericbouzy Interesting rule request! I hadn't considered that before.
My quick reaction is that one might more often want their it.todo
padding to match their it
padding since then they could just remove the .todo
, implement the test, and have valid padding at that point, but I do recognize that one form is typically multiline while the other is not and I can appreciate the aesthetic difference.
Could be an interesting rule to implement since, iirc, we don't look past the first token right now.
Disclaimer I'm just a contributor. :)
@dangreenisrael @hockeybuggy thoughts?
from eslint-plugin-jest-formatting.
I think having it as an option would be nice, but I won't have any time for it for at least the next 2 months.
@hockeybuggy Thoughts?
from eslint-plugin-jest-formatting.
@aymericbouzy No time like the present to learn something new. I learned with this course. https://frontendmasters.com/courses/linting-asts/
from eslint-plugin-jest-formatting.
Hey, I'm closing this due to a seeming lack of interest. If it can get 5 +1s I'll reopen it.
from eslint-plugin-jest-formatting.
Related Issues (20)
- [Rule] Add padding around describe blocks HOT 2
- Support ESLint 8.x HOT 2
- [BUG] Comments are dropped from before and after test blocks
- [Rule] Newline after setup and teardown HOT 2
- Node engines is very specific HOT 3
- [Rule] Newline before expect HOT 14
- [DOCS] Links are wrong in `docs/rules/padding-before-all.md` HOT 2
- Allow configurable test file pattern HOT 8
- Fix some weirdness with expression => expect => expression => expect HOT 11
- [BUG] TypeError when extend recommended config HOT 11
- [Rule Update] padding-around-expect-groups configuration/default HOT 4
- [BUG] Rules not properly marked as deprecated HOT 2
- [BUG] Property "overrides" is the wrong type HOT 11
- [BUG] GitHub releases are maybe broken HOT 5
- [BUG] undocumented rule: (padding-around-all) HOT 4
- [Rule] test name should be trimed HOT 9
- Support ESLint 7.x HOT 5
- [BUG] .nvmrc file needs an update HOT 6
- [BUG] `padding-around-expect-groups` wants space around `expect`s which are `await`ed HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eslint-plugin-jest-formatting.