Date output broken (bunq)

[danielhaitink]

Date output broken (bunq)

[Althestrasz]

Sorry, I realized I wrote parentheses but meant quotation marks. If you compare the bunq-en testfile to my submitted file, you noticed that the quotation marks are missing in the testfile.

[DanielHaitink]

Ah right! I will edit the test files then! Thanks for notifying me! 😄

[DanielHaitink]

Could you upload an input file? Copy pasting the input has shown to be error prone

[Althestrasz]

Here's an example:
2021-05-17_11-03-45_bunq-statement.csv

[DanielHaitink]

Apparently the date config is not correct in the banks.json. It says DD/MM/YYYY, whereas your version is YYYY-MM-DD. Would you happen to know if bunq updated its date format in the CSV? Did the YNAB converter use to work before?

[DanielHaitink]

I've pushed the change. Please check if it is working now. Maybe I should build a check to verify the dateformat, to make sure that these errors can't occur.

[Althestrasz]

Verified, issue is resolved! Thanks! As for the dateformat checking, I assuming checking the first line of entries would be enough, but I am not sure how much overhead that would add.

Apparently the date config is not correct in the banks.json. It says DD/MM/YYYY, whereas your version is YYYY-MM-DD. Would you happen to know if bunq updated its date format in the CSV? Did the YNAB converter use to work before?

As I wrote in my original issue submission, I used an archived CSV file from 2018 too and the issue was present with that file. I noticed that your testfile for bunq-en used DD/MM/YYYY but the Dutch equivalent does not (YYYY-MM-DD). It also misses the parentheses in the file header line of the CSV.

[DanielHaitink]

Ah sorry missed that part! So should be fixed now then. Not sure why the date settings were wrong in the json. Probably some oversight from the committee.

It also misses the parentheses in the file header line of the CSV.

What do you mean with that?