Object indexing false positive

[danielnixon]

Object indexing false positive

[tankers746]

Just tested, works great!

[danielnixon]

Have you bumped into #16 ?

[danielnixon]

https://github.com/danielnixon/eslint-plugin-total-functions/blob/master/src/rules/no-array-subscript.test.ts#L284-L296

[tankers746]

I have not yet, but would prefer that subscript access be split up into an array rule and an object rule. The rule for arrays, while not perfect, solves a pain point in typescript. I'm less concerned about object indexing which at least in my codebase is far more common than array indexing.

[danielnixon]

would prefer that subscript access be split up into an array rule and an object rule

That's a fair point. PR welcome, otherwise I'll get to it soonish.

[danielnixon]

For the object and array decoupling: #28

[danielnixon]

The explanation for this issue:

There's a limitation in the rule such that it won't consider non-literal keys (even if the key's type is keyof typeof ... or const).

So this won't (currently) pass the rule:

const period: keyof typeof periods = 'oneDay';
periods[period];

but this will:

periods['oneDay'];

This is the object cousin of the array limitation in #16.

Happy to accept a PR, otherwise I'll fix this soonish too.

[danielnixon]

This might be fixed by the latest release. Please update and let me know @tankers746