Giter Site home page Giter Site logo

Comments (3)

ihadeed avatar ihadeed commented on May 12, 2024

That would make the definitions a lot cleaner.

Wouldn't it also help if we ensure that every promise has a defined type
--example, like in geolocation.ts : Promise<Geoposition>, instead of
Promise<any> ? I think it will help the docs generation process as well.

from awesome-cordova-plugins.

tlancina avatar tlancina commented on May 12, 2024

Yeah I think if possible we should try and have the wrapper be as small as possible, and use interfaces for the option objects as well:

  /**
   * Show the ActionSheet.
   */
@Cordova()
  static show(options?: ActionSheetOptions) : Promise<any> { return }

  /**
   * Hide the ActionSheet.
   */
  @Cordova()
  static hide() : Promise<any> { return }

I also am not a huge fan of having the interfaces cluttering up the top of the files, it would be nice to have just the description of the wrapper, with the very concise method definitions. I can't remember if there is a good way to move them into their own files, while still using declaration: true. I want to say we have to concatenate them manually as part of the build.

Regarding the promises, I agree, if possible they should all have the correct type.

from awesome-cordova-plugins.

ihadeed avatar ihadeed commented on May 12, 2024

Is it something like this that you're looking for : https://www.npmjs.com/package/declaration-bundler-webpack-plugin ?

from awesome-cordova-plugins.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.