Comments (3)
That would make the definitions a lot cleaner.
Wouldn't it also help if we ensure that every promise has a defined type
--example, like in geolocation.ts : Promise<Geoposition>
, instead of
Promise<any>
? I think it will help the docs generation process as well.
from awesome-cordova-plugins.
Yeah I think if possible we should try and have the wrapper be as small as possible, and use interfaces for the option objects as well:
/**
* Show the ActionSheet.
*/
@Cordova()
static show(options?: ActionSheetOptions) : Promise<any> { return }
/**
* Hide the ActionSheet.
*/
@Cordova()
static hide() : Promise<any> { return }
I also am not a huge fan of having the interfaces cluttering up the top of the files, it would be nice to have just the description of the wrapper, with the very concise method definitions. I can't remember if there is a good way to move them into their own files, while still using declaration: true
. I want to say we have to concatenate them manually as part of the build.
Regarding the promises, I agree, if possible they should all have the correct type.
from awesome-cordova-plugins.
Is it something like this that you're looking for : https://www.npmjs.com/package/declaration-bundler-webpack-plugin ?
from awesome-cordova-plugins.
Related Issues (20)
- npm run build - command Failed HOT 1
- Geolocation find by address (forwardGeocode) HOT 1
- NFC Plugin implementation guide in Ionic React ?
- Problems with minimising the App. HOT 1
- SMS is not compatible with Angular Ivy
- Wrong top package.json field 'main' HOT 1
- Screen orientation plugin don't lock screen on ios 17 HOT 1
- Where to find real documentations? HOT 1
- Plugin bluetooth-le>RespondParams Interface> Missing optional property: address HOT 1
- download PDF file from external website with inappbrowser HOT 1
- Avoid `any` type and use tsdoc comment properly. HOT 1
- [BLE] Missing method `requestConnectionPriority`. HOT 1
- Creating Cordova Plugin HOT 1
- Add interface to diagnostic plugin HOT 1
- @awesome-cordova-plugins/local-notifications: getAllScheduled and getAllTriggered not working in Cordova HOT 1
- Is there any Unity3D plugin? HOT 1
- Plugin for Google Nearby Connections HOT 1
- social-sharing :: not working on onePlus device when share mp4 video. HOT 1
- Exception calling Diagnostic.requestBluetoothAuthorization method HOT 1
- Cannot find plugin.xml
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from awesome-cordova-plugins.