cordova-plugin-file support

[danielsogl]

cordova-plugin-file support

[ihadeed]

The code you have looks right to me ..
Do you have the plugin cordova-plugin-file installed?

[Fenkiou]

Yes, the plugin is installed. Maybe the plugin is missing the equivalent of $cordovaFileError and $window ?

[ihadeed]

Hey @Fenkiou ..

I was looking at the plugin's source code. The function getFreeDiskSpace() is not exposed in the plugin's JavaScript file. It is a function defined in the Java and Objective-C files only. Which explains why you aren't able to access it through the ionic-native wrapper you wrote.
Ref: https://github.com/apache/cordova-plugin-file/search?utf8=%E2%9C%93&q=getFreeDiskSpace

The ionic-native wrappers route your call to the plugin's methods that are defined in their JavaScript files (which is usually the methods they have documented).

You probably saw the method implemented in ngCordova and thought it's one of the plugin's methods. If you look at their code, they are actually executing the method using cordova.exec() which speaks to the Java/Object-C files directly without passing by the JS file.
Ref: https://github.com/driftyco/ng-cordova/blob/master/src/plugins/file.js#L27-L35

We might be looking to implement a similar approach to that method when we add the file plugin.

[Fenkiou]

Ok, I thought that ionic-native plugin wrap ngCordova plugin but it's the cordova plugin that is wrapped.

cordova.execis only used in getFreeDiskSpace(), and when I saw it, I tried to implement checkDir() method instead, like this :

@Cordova()
static checkDir(path: string, dir: string):Promise<any> {
  let resolveFn, rejectFn;
  let promise = new Promise((resolve, reject) => {resolveFn = resolve; rejectFn = reject; })

  var directory = path + dir;

  if ((/^\//.test(dir))) {
    rejectFn('directory cannot start with \/');
  }

  try {
    var directory = path + dir;

    window.resolveLocalFileSystemURL(directory, function (fileSystem) {
      if (fileSystem.isDirectory === true) {
        resolveFn(fileSystem);
      } else {
        rejectFn({code: 13, message: 'input is not a directory'});
      }
    }, function (error) {
      error.message = error.code;
      rejectFn(error);
    });
  } catch (err) {
    err.message = err.code;
    rejectFn(err);
  }

  return promise;
}

But it's not working anyway. Even with just something like this :

@Cordova()
static checkDir(path: string, dir: string): string {
  return "some string";
}

It's still raising an error on https://github.com/driftyco/ionic-native/blob/master/src/plugins/plugin.ts#L100 without tell me the error but it's this call that fails.

[ihadeed]

Adding the @Cordova() decorator overrides anything that's defined in your function.

[ihadeed]

This should work.

static checkDir(path: string, dir: string):Promise<any> {
  return new Promise((resolve, reject) => {
    var directory = path + dir;

  if ((/^\//.test(dir))) {
    reject('directory cannot start with \/');
  }

  try {
    var directory = path + dir;

    window.resolveLocalFileSystemURL(directory, function (fileSystem) {
      if (fileSystem.isDirectory === true) {
        resolve(fileSystem);
      } else {
        reject({code: 13, message: 'input is not a directory'});
      }
    }, function (error) {
      error.message = error.code;
      reject(error);
    });
  } catch (err) {
    err.message = err.code;
    reject(err);
  }

  });
}

[Fenkiou]

That's it, thank you ! I'll try to implement methods I need to see if it works and I hope get back with a PR.

UDPATE:
Your way to return promise causes a memory consumption issue, I used my way with @cordova() removed and it works.

[ihadeed]

@Fenkiou Thanks for feedback. Glad you got it working.