Comments (3)
First of all, contributing is always welcomed.
Regarding the features:
- This is supported at the moment for the latest timestamp only, Im planning of adding compression to the data, once we have compression its harder to update existing timestamp without a big overhead.
having said that, with the simple chunk interface we can support updating without a problem, I would be willing to accept a PR for that as long as it kept in the chunk level. - back filling is a problem, currently the chunk design is implmented in a way that adding a timestamp in a middle of a chunk is a not easy. you would need to move data around and possibly create a new chunk.
I can see an easy implementation if the timestamps you are backfilling are older then the oldest timestamp at the moment.
Another possible implementation for this would be done in the client side where you copy all the data from a key and re-insert it to another key.
from redis-timeseries.
I made a PR for (1) - #21
regarding (2) - I guess I'll do it on the client as you suggested :-)
Cheers.
P.S.
Just out of curiosity - Perhaps I'm just not familiar enough with how Redis manages modules, but I noticed that in ChunkItertorGetNext
and SeriesItertorGetNext
you're doing memcpy
and creating a copy of a Sample
, but never freeing that copy's memory. Doesn't it create memory leaks ?
from redis-timeseries.
Regarding the memory, memcpy
used for copying data around, it doesn't allocate more memory.
in SeriesItertorGetNext
we create a variable internalSample
on the stack, this variable location is passed to SeriesItertorGetNext
, when we exit the function this variable will be deleted from the stack.
Generally, the caller to ChunkItertorGetNext
and SeriesItertorGetNext
are incharge of allocating and releasing the memory.
from redis-timeseries.
Related Issues (20)
- Add TS.RANGE command complexity description HOT 2
- Question on chunks HOT 11
- Redis rdb save crashes if no samples yet HOT 1
- has it tested on arm? HOT 1
- Retain compaction context in rdb
- Calculate correlation between two keys
- Timestamp Too Old HOT 10
- Timestamp with milliseond precision HOT 1
- memory usage HOT 10
- Add NX argument to TS.CREATE HOT 4
- Support automatic timestamps for arbitrary values
- Support adding multiple or weighted values HOT 1
- Multiple compaction rules on a key cause crash on redis startup HOT 1
- Replacing the current value in a series corrupts aggregate values
- Timeseries starting from 0 are unsupported HOT 1
- How to use int64 timestamp HOT 1
- how does retentionSecs works? HOT 2
- Compilation Issue on MacOS Sierra v10.12.6 HOT 2
- Compressing timestamps HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from redis-timeseries.