Comments (3)
Interesting bug. Thanks for pointing it out.
from pokered-gbc.
The recent update has brought back this bug (it was originally fixed in 1531f6b). When the last unit of an item is used, wCurrentMenuItem
is set back to 0, causing healing items to animate the first Pokemon's palette always. The bug was reintroduced in 83f6d5e. To fix, replace the two wCurrentMenuItem
reads in DrawHPBarWithColor
with wLastMenuItem
.
I'm going through all the commits to port some things to my own hack (I'm mostly interested in low level engine changes than data changes but that's another story). The point is, if I notice anything else I'll point it out as well, but it could obviously be related to my own hack changes as well. I assume this particular bug is a thing in the clean color hack too since it used to be a bug for the same reasons.
For example, I think in was bfd0d7a which introduced a bug in my own version when sending a player Pokemon into battle (it was an issue with the bank not being restored properly but I didn't look further into it, since I had patched the pokemart corruption glitch with another far less clean solution that didn't involve clearing the di/ei block, so I just went back to it instead). I'm not sure if it could be due to interrupts timing in DelayFrameHook
and/or if it's a thing in the clean color hack at all and it was fixed in a latter commit.
from pokered-gbc.
dang it. forgot to come back to this and no one else has reported it for 5 years lol but confirmed it is still happening.
from pokered-gbc.
Related Issues (12)
- Build issue HOT 7
- White Screen When Selecting Starter Pokémon HOT 1
- Route 15 gate binoculars Articuno sprite displays incorrectly HOT 1
- Compatability with Universal Pokemon Randomizer ZX? HOT 2
- Language support? HOT 1
- How to get this to work on vc?
- Update build instructions repo url
- Bug: Player sprite disappears while using itemfinder HOT 2
- Fix pic sizes
- Possible Compilation Error With latest rgbds HOT 1
- Songs only playing one channel? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pokered-gbc.