Giter Site home page Giter Site logo

Comments (5)

h6ah4i avatar h6ah4i commented on August 16, 2024

Hi @danoz73, I'm trying to fix this issue and I want your opinion.

Section indicator is tightly connected to fast scroller and I think it should be declared in vertical_recycler_fast_scroller_layout.xml file. Why did you place the section indicator outside of this file?
If all of the section indicator, bar and handle views shares a common parent view (= RecyclerViewFastScroller), this issue can be fixed more easily.

from recyclerviewfastscroller.

h6ah4i avatar h6ah4i commented on August 16, 2024

Fixed in my forked branch.

https://github.com/h6ah4i/RecyclerViewFastScroller/tree/fix_section_indicator_position

(not PR yet, because other pending PRs conflicts to this modification)

from recyclerviewfastscroller.

dima-ko avatar dima-ko commented on August 16, 2024

@h6ah4i is it possible to fix this without changing the lib?

from recyclerviewfastscroller.

h6ah4i avatar h6ah4i commented on August 16, 2024

@insomnaicJustin Impossible. I have fixed many issues (including this issue) in my forked repository, but I have not pull requested yet because it is hard to resolve all conflictions 😞

from recyclerviewfastscroller.

Sebring avatar Sebring commented on August 16, 2024

I think this bug is pretty severe, specially as indicator now tends to show up under the finger =/

Would it help to rebase and re-apply to avoid conflicts? I guess it sounds to easy...

from recyclerviewfastscroller.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.