Error while using custom options

[danymat]

Error while using custom options

[theairbend3r]

Ah, I see. Thank you for the quick response @danymat! Love this plugin btw, amazing work! 😄

[kevinhwang91]

@danymat Have you reproduced this issue? I have reproduced it.

[theairbend3r]

Hey, it is working now!

It adds a string "binary_operator" in the Returns part of the docstring when there's no annotation. Is that by design?

def lol(x, y):
  """

  Parameters
  ----------
  x : 
   
  y : 
   

  Returns                                                                                                                                               
  -------                                                                                                                                               
  binary_operator                                                                                                                                       
                                                                                                                                                    
  """                                                                                                                                                   
  return x + y  

It works properly when the function has an annotation for return type.

  def lol(x, y) -> str:    
      """    
      
      Parameters    
      ----------    
      x :     
              
      y :     
              
      
      Returns    
      -------    
      str    
              
      """    
      return x + y 

I've also noticed while testing this out the *args, **kwargs don't show up. See def module_level_function(param1, param2=None, *args, **kwargs): in the Sphinx's NumPy style Python docstrings. Should I create a new issue for this or is it fine here?

def lol(x, y, *args, **kwargs) -> str:
    """                                                      
  
    Parameters  
    ----------  
    x :   
          
    y :   
          
  
    Returns  
    -------  
    str  
          
    """  
    return x + y  

[danymat]

Hello, you can reference your two problems in a new issue !
I am closing this issue as it seems resolved

[danymat]

Hello, can I see your neogen config ?
Did you called the setup() function ?

[theairbend3r]

Here's my neogen config-

-- load neogen                                           
local is_neogen_installed, neogen = pcall(require, "neogen")    
if not is_neogen_installed then                                                                                                             
    vim.notify("neogen is not installed.")                                                                                                  
    return                                                                                                                                  
end                                                                                                                                         
                                                                                                                                            
local opts = { noremap = true, silent = true }                                                                                              
local keymap = vim.api.nvim_set_keymap                                                                                                      
keymap("n", "<Leader>gg", ":lua require('neogen').generate()<CR>", opts)                                                                    
                                                                                                                                            
neogen.setup({                                                                                                                              
    enabled = true,                                                                                                                         
    languages = {                                                                                                                           
        python = {                                                                                                                          
            template = {                                                                                                                    
                annotation_convention = "numpydoc",                                                                                         
            },                                                                                                                              
        },                                                                                                                                  
    },                                                                                                                                      
}) 

Here's how I installed it.

use({
    "danymat/neogen",
     requires = "nvim-treesitter/nvim-treesitter",
}) 

I'm running neovim 0.6.1 and the latest version of neogen.

[danymat]

Hello, it seems that latest refactor did cause some bugs in that regard

(cc @kevinhwang91) Seems to be the setmetatable in configuration that is not called:

• here:

  neogen/lua/neogen/generator.lua

  Lines 163 to 170 in e5031f4

  	local language = conf.languages[filetype]
  	if not language then
  	notify("Language " .. filetype .. " not supported.", vim.log.levels.WARN)
  	return
  	end
  	typ = (type(typ) ~= "string" or typ == "") and "func" or typ -- Default type
  	local template = language.template
  	if not language.parent[typ] or not language.data[typ] or not template or not template.annotation_convention then

• even here:

  neogen/lua/neogen/init.lua

  Line 146 in e5031f4

  local ft_conf = filetype and conf.languages[filetype] or conf.languages[vim.bo.filetype]

  .
  Can you take a look?.

I will try to come up a fix quickly today if @kevinhwang91 is not active

[kevinhwang91]

Please try #67

[danymat]

Hello, i merged the fix @kevinhwang91 did, can you try out ?