Comments (3)
@dete As you suspected, here are two more than can be constant
https://github.com/axiomzen/cryptokitties-bounty/blob/03b51a8872d2438851d0ef77cfe29c74a079d26a/contracts/KittyOwnership.sol#L13
https://github.com/axiomzen/cryptokitties-bounty/blob/03b51a8872d2438851d0ef77cfe29c74a079d26a/contracts/KittyOwnership.sol#L14
from cryptokitties-bounty.
promoCreationLimit and gen0CreationLimit are both defined as variables
Weirdly, I just learned about constant
Solidity variables just this morning, I think there some others we can probably fix, also.
createPromoKitty increments both variables
Your suggestion would result in two reads (instead of one) in createGen0Auction
, but it's still a net gas savings. We'll definitely look at this!
Thanks again, @Arachnid! Love these reports!
from cryptokitties-bounty.
Thanks for your participation, @Arachnid! Our team has reviewed your submission, and we are pleased to reward you for your report.
Impact: Low
Likelihood: Low
Points: 50
Please see the final leaderboard here.
from cryptokitties-bounty.
Related Issues (20)
- check in modifier (canBeStoredWith128Bits) HOT 2
- bid amount: comment vs code HOT 2
- Hardcoded numbers HOT 1
- unbounded loop HOT 2
- Functions' visibility HOT 2
- Possible alternative to rescueLostKitty function HOT 1
- Possibly missing implementation of intended functionality HOT 2
- Auction DoS possibility still problematic HOT 2
- When kitty gives birth in the ownership of SaleClockAuction, offspring becomes locked HOT 2
- CEO could transfer entire balance to a seller HOT 1
- CryptoKitties Bounty Is Now CLOSED! HOT 1
- Final Leaderboard HOT 6
- Limit gasPrice in auctions HOT 1
- Reason behind short-term stable randomness for GeneScience contract
- setCEO error HOT 1
- Code is open source HOT 1
- Typo in the CryptoKitties_WhitePapurr_V2 HOT 1
- 0x0ae4cAcDe6b5a0d31369b311658e5897ED6b9938 HOT 2
- yy
- 0x0ae4cAcDe6b5a0d31369b311658e5897ED6b9938
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cryptokitties-bounty.