Giter Site home page Giter Site logo

Comments (6)

pik avatar pik commented on July 29, 2024 1

@darkguy2008 Thanks! It may seem uncommon in the JS ecosystem but e.g. with Python checking version is a pretty common way to make a single code-base / library compatible with both Python versions. I could provide a quick-patch if it's desired.

from parallelshell.

darkguy2008 avatar darkguy2008 commented on July 29, 2024 1

Hi all, sorry for the delay, I've been really busy with work but I got a notification here and set up some time to test and tidy up the repo a little bit. The PR has been merged, I need to update the packages and whatnot now πŸ‘ thanks @pik !

from parallelshell.

darkguy2008 avatar darkguy2008 commented on July 29, 2024

Hello!

I see, well, the < 2.1 version does work with < Node8, and 3.0+ with >= Node8, but then again you do have a point and it seems to be a small fix, although I don't like much to create a dependency by checking the runner's version inside a library, it's useful for node < 8 users.

I'm sorry I didn't add this before, I will do it right away. Thanks for your concern! πŸ‘

from parallelshell.

darkguy2008 avatar darkguy2008 commented on July 29, 2024

@pik thanks for your insights, it makes sense now :). I've been a bit full these days and from what I could see, the variable should be process.versions.node... I could check if process.versions.node[0] == '8' but I'm not sure if that's okay... I'd need some time to set up different node envs to try. If you are able to make a patch, I'll happily review it and apply it immediately, what do you think? :D

from parallelshell.

t3chguy avatar t3chguy commented on July 29, 2024

@darkguy2008 @pik made a patch

from parallelshell.

Nostradamos avatar Nostradamos commented on July 29, 2024

Did anyone try to contact @darkguy2008 on other channels (eg his email)?
Would love to see this PR merged.

from parallelshell.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.