Comments (6)
@darkguy2008 Thanks! It may seem uncommon in the JS ecosystem but e.g. with Python checking version is a pretty common way to make a single code-base / library compatible with both Python versions. I could provide a quick-patch if it's desired.
from parallelshell.
Hi all, sorry for the delay, I've been really busy with work but I got a notification here and set up some time to test and tidy up the repo a little bit. The PR has been merged, I need to update the packages and whatnot now
from parallelshell.
Hello!
I see, well, the < 2.1 version does work with < Node8, and 3.0+ with >= Node8, but then again you do have a point and it seems to be a small fix, although I don't like much to create a dependency by checking the runner's version inside a library, it's useful for node < 8 users.
I'm sorry I didn't add this before, I will do it right away. Thanks for your concern!
from parallelshell.
@pik thanks for your insights, it makes sense now :). I've been a bit full these days and from what I could see, the variable should be process.versions.node
... I could check if process.versions.node[0] == '8'
but I'm not sure if that's okay... I'd need some time to set up different node envs to try. If you are able to make a patch, I'll happily review it and apply it immediately, what do you think? :D
from parallelshell.
@darkguy2008 @pik made a patch
from parallelshell.
Did anyone try to contact @darkguy2008 on other channels (eg his email)?
Would love to see this PR merged.
from parallelshell.
Related Issues (20)
- Why BrowserSync over Webpack-dev-server? HOT 1
- Issue with assigning variables HOT 5
- Feature request: Prefix output with (colored?) indicator of which process it came from HOT 1
- Suggestions for why parallelshell breaks node-notifier?
- Some output goes to the wrong terminal tab with two tabs open HOT 4
- Same argument passed to all shells? HOT 1
- Exit code is 0 when first command succeeds and second fails HOT 4
- fails on node8 HOT 3
- child_process throwing error ('"cwd" must be a string') HOT 24
- /usr/bin/env: βnode\rβ: No such file or directory ... HOT 9
- TypeError: "cwd" must be a string HOT 3
- New release? HOT 5
- Node 10.x version check fails HOT 9
- child_process throwing error ('"cwd" must be a string') HOT 2
- ERR_INVALID_ARG_TYPE error for Node v10.5.0 HOT 7
- The "options.cwd" property must be of type string. Received type function HOT 36
- Please do a release with the version check fork! HOT 7
- The "options.cwd" property must be of type string. Received type function HOT 1
- npm ERR! code ELIFECYCLE HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from parallelshell.