Update for API Keys

[jaredl531]

Update for API Keys

[darrynten]

@clone1018 I need you to please make the change to #46 so that we can merge this in and release. Thank you.

[nzsakib]

Agree ,
I cannot use the library anymore as I don't have any CLIENT_ID/ SECRET keys.

Please implement the API keys.

[eddiezane]

@darrynten - I started taking a stab at implementing this and saw that we're currently using /v1/token for every request

clarifai-php/src/Request/RequestHandler.php

Lines 158 to 177 in eba3244

	private function requestToken()
	{
	$tokenResponse = $this->handleRequest(
	'POST',
	$this->url . '/v1/token', // endpoint is available only in v1
	[
	'form_params' => [
	'grant_type' => 'client_credentials',
	'client_id' => $this->clientId,
	'client_secret' => $this->clientSecret,
	],
	]
	);
	$this->tokenExpireTime->modify(
	sprintf('+%s seconds', $tokenResponse['expires_in'])
	);
	$this->token = $tokenResponse['access_token'];
	$this->tokenType = $tokenResponse['token_type'];
	}

API Keys do not work with this endpoint/session tokens.

We're still finalizing plans but will most likely be moving to dropping v1 support by the end of this year. Also all newly created apps only have API keys (which it seems @nzsakib encountered above).

I see two options:

• Add logic to handle not grabbing a session token if we're using an API Key
• Drop support early for v1

What are your thoughts?

[darrynten]

@mxnr @vojtik do you guys perhaps have any ideas around this?

[darrynten]

Hi @eddiezane and @jared-clarifai

There is a PR open #46 that lays some groundwork for this, but it breaks backwards compatibility.

On that note, and regarding:

We're still finalizing plans but will most likely be moving to dropping v1 support by the end of this year.

Does this mean that any and all production apps in the wild will be broken come Jan 1 if they are not migrated to API keys, or will they be "grandfathered"?

Keen to get this resolved 🚀

[eddiezane]

@darrynten will take a look at the PR.

Does this mean that any and all production apps in the wild will be broken come Jan 1 if they are not migrated to API keys, or will they be "grandfathered"?

That is all still being discussed and worked out but my gut feeling is we'll be turning off support completely and there will be plenty of notice and an upgrade path.

[darrynten]

Hi all, PR #46 is close to being ready, there are only some minor change requests left.

[darrynten]

This was just resolved!

A new release, 1.0.0 has been published.

Thanks to @jared-clarifai @unclecheese and @clone1018

#49