Comments (10)
I think this is the best analyzer API to use, to map to the symbol search. We may still want the API extended to show more things (Foo.ba
would show something like Foo.bar
).
from dart-code.
Do you think it's worthwhile me sending two requests (as mentioned here) in the meantime? I think Code users would probably expect class methods/properties to appear in the search and it feels a bit limited as it is.
from dart-code.
I haven't used the other APIs - are they used for searching for a member
given a class? Or for any member in a project?
There's a separate vscode api for symbols within a file. That may make the
most sense to map to the analyzers outline api.
from dart-code.
findMemberDeclarations looks very similar to the one I'm currently using; it's just global search for declerations with that name (though it might only do full matches and no pattern). I might have a go at merging results from both and see how it feels; certainly the current behaviour doesn't feel as useful as I would expect. I guess I could also compare results with some sample code on both TS and Dart.
from dart-code.
/cc @bwilkerson @scheglov
from dart-code.
I did also post to analyzer-discuss if it's more helpful for others if the discussion happens there.
from dart-code.
@devoncarew I've implemented merging of these two for now. Seems to work ok for me (though I discovered a crazy bug in the process - microsoft/vscode#10446) but if you have a minute to test it I'd be interested in your opinion.
It works more like Ctrl+T
for TypeScript now (eg. it'll include things from your imported packages, etc.). I think it might be both more and less useful at the same time.
I have not yet put any wildcard characters in (as suggested by @bwilkerson here) because it seems to already return things that start with what I pass (and I'm concerned when it gets fixed it'll just break and come less useful).
from dart-code.
Awesome! I'll will give it a shot; I'm set up for development on my machine at home; also looking forward to the next release :)
from dart-code.
I'm planning on pushing a release out tomorrow. I might try and get #53 in first; I think it'll help me as a Dart noob (I keep meaning to sit down and actually try to write something real in Dart in it but it hasn't happened yet!).
from dart-code.
Going to consider this done for now; I think it's the best we can do. If the AS gets a new API in an upcoming version, I'll switch to it (though need to consider what to do if an old SDK is being used - something I've ignored for now... who knows what this thing does with an old SDK AS)...
from dart-code.
Related Issues (20)
- Dart pub get does not respect VSCode env variables HOT 2
- Stateful Widget snippet adds additional underscore to State class name if Widget name starts with an underscore HOT 1
- Update dependencies tree to support Pub workspaces
- The suggestion stuck on loading stats for a long time HOT 1
- yellow bulb HOT 1
- Dart.exe Eating All Memory HOT 7
- Closing labels don't update correctly when a file is not the active editor
- VSCode Auto-Import-Complete broken, too many import suggestions HOT 1
- Dependencies tree doesn't work correctly in Pub Workspaces
- Flutter stderror output is not correctly decoded in verbose debugging logs ("dart.log" events) HOT 1
- Renaming files triggers `uri_does_not_exist` HOT 1
- Improve error message for Linter warning: lower_case_with_underscores / dart(file_names) HOT 4
- Sidebar doesn't work in web contexts because DTD URI is not exposed HOT 1
- The "Open Log" button on generic prompt to reload should be more targetted
- Auto imports broken on third party packages HOT 13
- m HOT 1
- m HOT 1
- Widget Inspector incompatible size in vscode HOT 1
- Triggererd breakpoints are not resetting on restart HOT 2
- [DevTools] Add toggle for showSemanticsDebugger HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dart-code.