add sdk to path on windows not working cause the path is quoted

[wildsylvan]

add sdk to path on windows not working cause the path is quoted

[DanTup]

btw dart collect diagnostic information reports my windows version as: on windows / "Windows 10 Pro" 10.0 (Build 22631), while it's Windows 11 Pro 10.0.22631 Build 22631. is it normal?

I see this too... The version nubmer for Windows 11 is still 10, but I think this is a bit misleading. I've opened dart-lang/sdk#55351 (that info comes from running dart info internally).

[DanTup]

Thanks, I can repro. We were deliberately adding extra quotes and I had a comment that it didn't work without them:

Dart-Code/src/extension/commands/add_sdk_to_path.ts

Lines 96 to 97 in b217782

	// If we don't re-quote this, spaces break, even though runToolProcess is doing it?
	`"${sdkPath}"`,

However, I just removed them and it's working fine. Maybe something changed in newer versions of PoSh, I'm not sure - but I'm going to remove them since everything seems fine (even with spaces in the path) for me now.

[wildsylvan]

see also: #4604 (comment)

[wildsylvan]

btw dart collect diagnostic information reports my windows version as: on windows / "Windows 10 Pro" 10.0 (Build 22631), while it's Windows 11 Pro 10.0.22631 Build 22631. is it normal?

[DanTup]

@wildsylvan can you confirm exactly where you're seeing these quotes? I just used this command but the path looks correct both in Windows env variables dialog and in the terminal in VS Code:

[wildsylvan]

to see it from the dialog you have to click on edit text...