Comments (3)
Turns out we already support this. The types did not suggest so (which was fixed in 04dbe4e) but the code was all good (since in TS, debugSessionId as string
doesn't do anything, and allows the null/undefined through!).
Just needs some testing from DevTools.
from dart-code.
I tested this by forcing a null debug session ID in DevTools sidebar:
Then launched two debug sessions and tried to open Inspector from the DevTools sidebar. It prompted for a debug session as expected:
This is because it goes through the usual code path for launching DevTools pages and that checks whether the target page requires a debug session and if one wasn't provided will prompt.
@kenzieschmoll the DevTools API classes already allow for null here too, so this is implementable today. If you pull the DevTools buttons up to the top level and pass null
here, it'll do what we want.
from dart-code.
Actually, that's not the full story... The check for whether we need require a debug session / VM Service looks like this:
const page = devToolsPages.find((p) => p.id === pageId);
const requiresVmService = page && !page.isStaticTool;
So if we don't recognise the page
, we'll assume a session is not required. This will be problematic for extensions (which Dart-Code doesn't know about).
So we need an API change to allow DevTools to dictate whether we prompt for a session or if one is not necessary (because it's a static tool). I'll look at adding something to support this distinction.
from dart-code.
Related Issues (20)
- Debug breakpoints not triggering on iOS devices HOT 6
- Make it clearer which settings only apply to legacy analysis server protocol (additionalAnalyzerFileExtensions, analyzeAngularTemplates) HOT 1
- Make the display of getters/fields consistent
- Clean install on windows 11 using Visual Studio fails HOT 2
- [Macros] "Go to Augmentation" for library + CodeLense HOT 3
- Reload the Flutter sidebar from VS Code when the Flutter version changes HOT 3
- [Feature request] Make multi-line string literals foldable HOT 2
- When writing Flutter code in VSCode, there is no automatic indentation when breaking lines within the brackets {} HOT 5
- Quick fix for "Add missing switch cases" does not add all quick fixes HOT 1
- Add custom web server response headers when debugging a Flutter web app on VS code HOT 4
- Code keeps stoping at Disabled Breakpoints HOT 11
- Remove --ios-language for Flutter > 3.22 and update setting description
- Support syncing select debug session into the sidebar HOT 1
- Closure completion suggestions should include types when always_specificy_types lint is enabled HOT 4
- "Open DevTools (in Browser?)" option doesn't work HOT 1
- No parameter hints when invoking a callable class HOT 1
- Workspace name/folder as macro for log
- Dart daemon left hanging when IDE was closed HOT 7
- "URI scheme 'c' is not supported" error using analyzer plugins with Dart 3.5 pre-release HOT 16
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dart-code.