Needs to be updated to support Dart 1.16 service protocol

[dart-lang]

Needs to be updated to support Dart 1.16 service protocol

[travissanderson-wf]

We are seeing the same thing with our build systems

[kevmoo]

FYI: I'm working hard to get this resolved

I'm almost ready to land the fix (https://codereview.chromium.org/1929063002/) for the blocking issue (dart-archive/vm_service_client#6)

I've already started on migrating the coverage package to this.

[kevmoo]

With this pull request - #108 - we have the ability to connect to a running dart app (with the vm service enabled) and collect LCOV coverage info.

I'll work with @cbracken to review the code. If you're itchy to get coverage working on your app, you could try out the code on your own box.

I've cleaned up the API and the binaries A LOT. Let me know if you miss anything I've removed.

[kevmoo]

Related - dart-archive/vm_service_client#6

[travissanderson-wf]

Thanks for the update, I saw movement in the vm_service_client and figured as much but appreciate the post.

[kevmoo]

We've got the vm_service_client updated.

I'm doing work here - https://github.com/dart-lang/coverage/tree/migration

I'd really like to parse down what coverage does.

Is anyone consuming it for something other than coveralls.io?

[pulyaevskiy]

I have couple builds for codecov. Would be happy to help

[evanweible-wf]

@kevmoo all of our packages at Workiva use codecov, although we collect coverage via dart_dev. It essentially just combines the two steps from this package (collect and format) into a single task, handles merging coverage if the package has multiple suites, and a few other things like auto-generating an HTML file and generating the HTML report. It's always been brittle though, so I'm not opposed to change. I'm also happy to help!

[kevmoo]

@evanweible-wf do you have sample code? What format do you use for upload, etc?

[evanweible-wf]

Sure. The reporting to codecov part is easy, they supply a bash script that takes a correctly formatted coverage file (lcov, gcov, json, etc):

pub run dart_dev coverage --no-html
bash <(curl -s https://codecov.io/bash) -f coverage/coverage.lcov

https://github.com/Workiva/w_transport/blob/master/.travis.yml#L13-L14

The coverage task in dart_dev handles running the coverage executables across a set of test files and producing a single .lcov file: https://github.com/Workiva/dart_dev/blob/master/lib/src/tasks/coverage/api.dart

[donny-dont]

@kevmoo I use https://aircover.co/ for my stuff. It takes in lcov and then pushes it to the server. The pushing is done in a plugin so the lcov just needs to be hanging out somewhere on the disk.

[cbracken]

For anyone who needs SDK 1.16.0 support straight away while #108 is in review, I've pushed a branch containing the version we use inside Google for code coverage. It's a fairly minimal patch on a slightly older release than what's on master, but has the advantage of being entirely backward-compatible and feature identical to the currently released version while working on newer SDKs.

Will discuss with @dgrove and @nex3 early next week to decide on the approach we want to take to get something released.

[cbracken]

Closed by 521c4e5. Released in version 0.7.4.

[alexander-doroshko]

Verified that coverage works again in WebStorm 2016.2, thanks a lot!

[cbracken]

Thanks for verifying!