Coverage report miss for external functions

[dart-lang]

Coverage report miss for external functions

[cbracken]

@jacob314 for package:js. Not familiar with the implementation of dart:js in Dartium, but is it possible we're not generating hits in cases like this?

[jacob314]

That case would be really hard to support in Dartium. The problem is in that behind the scenes Dartium is implementing TestMe with noSuchMethod so the "external int returnFive()" isn't really being called. I'd recommend ignoring external methods when tracking your code coverage. DDC should be a much better job at tracking code coverage across the dart-JS boundary.

[cadencefinch-wf]

@jacob314 What are you referring to with DDC?

[zoechi]

https://github.com/dart-lang/dev_compiler

[cbracken]

The current implementation of coverage puts any given line in one of three states:

• Hit
• Miss
• Not coverable

If we can't support marking external lines as hit, we should at least ensure that they're not coming back as a miss.

@brettonfinch-wf can you clarify whether the line is coming back with a hit count of 0 (miss) or not included in the generated coverage at all (not coverable)?

[cadencefinch-wf]

The lines are coming back with a hit count of 0, my project uses CodeCov and it reports those lines as red (missed)

[cbracken]

Alright - sounds like if it's going to be too painful to get Dartium fixed, in particular with DDC coming, then marking em as un-coverable sounds like the way to go for now. Thanks for confirming!

[cadencefinch-wf]

Alright, that sounds good to me, thanks for confirming this!

[cbracken]

Closing as obsolete now that Dartium support is gone. dart-lang/test#36 tracks coverage for Dart for Web scenarios.