Giter Site home page Giter Site logo

Comments (10)

rekire avatar rekire commented on July 29, 2024 1

To simplify this issue: The output could suggest to use that lint warning. With that hint I would have not opened this issue.

from pana.

srawlins avatar srawlins commented on July 29, 2024 1

Sorry for my delayed response. I thought to myself "Could I implement this real quick in dartdoc? How would I do that?" And realized I should look into the warnings system. It turns out we have one warning in place: no-library-level-docs. I can't remember exactly now, but I think warnings are enabled with dart bin/dartdoc.dart --warnings no-library-level-docs.

Checks for docs for public API will probably be trickier, because of inheritance. 😬

from pana.

goderbauer avatar goderbauer commented on July 29, 2024

There's also the public_member_api_docs lint [1] that flags all members missing API docs. That's what we use in the Flutter framework to make sure everything is documented.

cc @srawlins for dartdoc.

[1] https://dart.dev/tools/linter-rules/public_member_api_docs

from pana.

sigurdm avatar sigurdm commented on July 29, 2024

@rekire does the public_member_api_docs lint work well enough for you? That should give you a list of all missing docs when you run dart analyze (or right in the IDE).

from pana.

rekire avatar rekire commented on July 29, 2024

I would need to check again, but I guess it is missing the library; statements.

Edit: My assumption was right pana want those library; statements with documentation, while the public_member_api_docs linter does not expect it.

But to be honest that is nothing wild anymore.

(Unfunny) Funfact: Regarding that lint, in that special project I accidentally disabled that lint rule.

from pana.

sigurdm avatar sigurdm commented on July 29, 2024

We should probably align between that lint and the dartdoc requirement.
My gut feeling says that the lint should also cover libraries...

from pana.

sigurdm avatar sigurdm commented on July 29, 2024

Ah - of course - let's do that!

from pana.

isoos avatar isoos commented on July 29, 2024

To simplify this issue: The output could suggest to use that lint warning. With that hint I would have not opened this issue.

In itself such lint would not be enough to 1:1 mirror the current analysis, which has a threshold for reporting missing API docs (currently at 20%), as the lints would only return the missing ones, and we are missing the total count of API symbols.

However, if you are only interested in having all your API symbols documented, by all means use the lint, as it will give you the feedback much faster than running dartdoc as a separate process.

from pana.

rekire avatar rekire commented on July 29, 2024

I had out of the box more then 20% I just aimed to have 100%. Might be also some hint of the library; statement would be nice ether. I was not aware of that keyword before I tried to get 100%.

from pana.

sigurdm avatar sigurdm commented on July 29, 2024

Opened dart-lang/linter#4962 for alignment on the lint. Closing this issue as I don't think we want to do more in pana.

from pana.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.