Timeout Improvements

[dashwav]

Timeout Improvements

[dashwav]

I created a branch Christmas-miracle (probably should change the name) for the new implementation of this

[dashwav]

First implementation idea:
Iterate through all the react-assign messages, grab all the users that reacted to the message and remove the user's perms from the target_channel of the message. When .untimeout is ran, go through the channels again and restore perms to the target_channels that the user reacted to.

Benefits:
No need to store any DB values
No need for user to re-react to any channels to gain access again.
Simple to code and maintain

Issues:
For some reason message. for user in message.reactions (seen here)[https://github.com/dashwav/nano-chan/blob/christmas-miracle/cogs/moderation.py#L122 ]isn't a reliable function. When I run this command with my alt as the user it only finds the user in 1 out of 12 channels the user has reacted in.

If I am just doing something dumb this is still the route I would like to take, but I am doubtful

[dashwav]

Second Implementation idea:
Iterate through all the target_channels and view the users individual permissions using permissions_for Found here. If the user has access to the channel, deny the permission.

Benefits:
Might actually work
Much quicker, less logic

Issues:
This would be very frustrating for a single day timeout, because all of the reacts would still be there, meaning the user would have to go through and double react on each channel they want back into.

[dashwav]

Last Implementation idea:
Same as the second implementation, except a list of all the channels the user has been removed from is kept and stored in the database, and when .untimeout is called, the list is restored, and the user given access back to the channels they were removed from.

Benefits:
End user functionality same as first implementation
More consistency, less user frustration than second implementation

Issues:
Much more complex than the other two ideas
Have to create and manage db table.