build.sh does not handle dependencies

[datacharmer]

build.sh does not handle dependencies

[datacharmer]

The process should be really simple, and I will add this to the documentation:

~$ echo $GOPATH
 /home/gmax/go
 ~$ mkdir go
 ~$ cd go

Here I have an empty go directory. I need just one command to get the package and its dependencies:

~/go$ go get github.com/datacharmer/dbdeployer

~/go$ ls -l src/
total 4
drwxrwxr-x 4 gmax gmax 4096 Apr 11 20:45 github.com
~/go$ cd src/github.com/datacharmer/dbdeployer/

~/go/src/github.com/datacharmer/dbdeployer$ ls
abbreviations  Changelog  CNAME   concurrent   defaults  LICENSE  mkreadme  README.md  test
build.sh       cmd        common  _config.yml  docs      main.go  pflag     sandbox    unpack
~/go/src/github.com/datacharmer/dbdeployer$ ./build.sh linux 1.1.1
+ env GOOS=linux GOARCH=386 go build -o dbdeployer-1.1.1.linux .
-rwxrwxr-x 1 gmax gmax 4.4M Apr 11 20:46 dbdeployer-1.1.1.linux
-rw-rw-r-- 1 gmax gmax 1.7M Apr 11 20:46 dbdeployer-1.1.1.linux.tar.gz

[datacharmer]

Also, if you want to compile on your own, please read this notice about pflags.
I will consider your suggestion about vendor, but I want to avoid distributing code from others into my repository. I have several tests that check the behavior of the code that depends on external packages and I will deal with breakages when I see one.

[datacharmer]

I have updated build.sh to check dependencies and give advice on how to build.
Thanks for raising awareness about this issue.
The solution may not be final. Please iterate if you get more problems.

[sjmudd]

Hi Giuseppe.

Thanks for your comments and the update. golang version dependency management is planned to get better so maybe this will soon be a non-issue. Having had some bugs due to the dependent libraries changing I still like the idea of recording that somewhere if possible.

[datacharmer]

I have changed my mind about using a vendor folder, and I am experimenting with it using govendor.
The pflags problem would be avoided completely, and it would possibly allow me to enhance usability by playing with cobra defaults.

[datacharmer]

Fixed (better) in version 1.8.3