Comments (11)
Hello @omajid ,
thank you for this information. The inline code should stand out more from the normal text.
I think this is a very important feature and I will prioritize this now over the others. 👍
from hugo-vitae.
@omajid I've added some styling for inline code now. Please let me know what you think of it.
I will wait for your reply before I create a new release with this feature included.
from hugo-vitae.
Thanks for the quick fix. I have one piece of feedback: due to the colour choices, it's almost impossible to distinguish a code that is a link from a code that's not. Here's an example:
Here musl
is supposed to be a link, but glibc
isn't. Even github highlights them differently, but vitae doesn't 😢
from hugo-vitae.
@omajid oh yeah not a great idea to make the color the same as the links. I'll fix that. 👍
from hugo-vitae.
@omajid I've fixed the text color now and made the background a bit darker. Please again let me know what you think.
from hugo-vitae.
Thanks, that mostly solves all my concerns. I don't quite have an artist's eye, so I can't really say if making it darker is a good idea or not.
from hugo-vitae.
Thanks, that mostly solves all my concerns. I don't quite have an artist's eye,
so I can't really say if making it darker is a good idea or not.
What is your personal opinion about the darker background?
Unfortunately I am not in a position to judge this for myself because I have not used it so often.
That is why your opinion about the background is so important to me. 👍
from hugo-vitae.
What is your personal opinion about the darker background?
I don't have a designer's sense of colours. I tried tweaking some colour values, and it seems like something just a little big lighter (#F1F1F1
, compared to the current #E1E1E1
) might be better?
In my own quick tests, it looks like the lighter the background colour, the easier it is to tell whether the inline-code is a link or not. With #F9F9F9
, for example, it's easier to tell link vs non-link in-line code snippets apart.
You can try this out on your end with this sample markdown that I used:
There are other C libraries on Linux too, such as
[`musl`](https://musl.libc.org/), but `glibc` is the most common one.
#F9F9F9
:
#F1F1F1
:
#E1E1E1
:
(Or am I just seeing bad colours on my end?)
from hugo-vitae.
I will go with the color #F1F1F1
, because with this background color it is neither too dark nor too light.
After I've changed that I will create a new release. 👍
Thank you for your help @omajid.
from hugo-vitae.
Thank you very much for your help on this issue @omajid. 👍
I've made the changes as written in my last post and will now close this issue.
from hugo-vitae.
Thanks for fixing this so quickly!
from hugo-vitae.
Related Issues (20)
- All links have a trailing space
- Internal templates are not available HOT 4
- Feature: Disable dark mode functionality
- Create templates for issues and pull requests
- Rework the "set dark mode as default" feature
- Code in hyperlink doesn't render HOT 2
- math rendering example HOT 4
- use safeURL HOT 2
- Source for default list page header prefers `.Data.Term` over `.Page.Title` HOT 6
- Dark mode icon is not shown if no social links are specified HOT 1
- Term with hashtag causing 404 error HOT 2
- [Question] How to put more posts on homepage? HOT 6
- Dark mode markdown codeblock background is white HOT 7
- readability issues in tables HOT 1
- Support for Persian? HOT 5
- When blog is in a subdirectory, resources does not load HOT 5
- Installation instructions not working HOT 1
- `customcss` isn't properly supported
- There must be at most one H1 tag in a page for SEO's sake HOT 3
- How to use math typesetting?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hugo-vitae.