Giter Site home page Giter Site logo

Comments (5)

lchayoun avatar lchayoun commented on July 17, 2024

Adding to that, the example configuration for the kafka integration has much more options that what is available through the template.

It would be great to add a way to control all of those options.

from chef-datadog.

albertvaka avatar albertvaka commented on July 17, 2024

Thanks for reporting this! Indeed, the kafka config template provides some pre-defined metrics that we should probably remove and leave up to the user to configure. Unfortunately this is most likely a breaking change, so we might need to hold that change until the next major version. However, in the meantime, note you can set any check config you want by using the datadog_monitor resource, which simply takes a dictionary with the config you want to set. See the instructions here: https://github.com/DataDog/chef-datadog#datadog_monitor

from chef-datadog.

lchayoun avatar lchayoun commented on July 17, 2024

Hi @albertvaka, thank you for the quick response.
I think that we can use the version (['datadog']['kafka']['version']) and in version 3 enable the new behavior.

from chef-datadog.

albertvaka avatar albertvaka commented on July 17, 2024

@lchayoun I've implemented your suggestion in #776 :) Can you give it a look?

from chef-datadog.

lchayoun avatar lchayoun commented on July 17, 2024

LGTM 😃

from chef-datadog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.