Java agent not working with Spring Boot 2 Reactive (Netty)

[ctoestreich]

Java agent not working with Spring Boot 2 Reactive (Netty)

[duke-cliff]

@tylerbenson Just verified it's working properly. 👍

[tylerbenson]

@duke-cliff Would you be able to create a separate issue for this? It would also help if you could provide a small sample app that demonstrates the problem. Thanks!

[ctoestreich]

I can confirm that switching to use the following fixes the traces.

<dependency>
	<groupId>org.springframework.boot</groupId>
	<artifactId>spring-boot-starter-web</artifactId>
</dependency>

I also tried using a non-flux/mono endpoint when running Netty, but this didn't fix the issue as both of these do not trace when using flux/Netty

 @RequestMapping(value = "/", produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
    public Mono<Response> index() {
        return Mono.just(new Response("OK"));
    }

    @RequestMapping(value = "/home", produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
    public Response index2() {
        return new Response("OK");
    }

[tylerbenson]

Thanks for your report. The netty framework is on our short list of things to instrument. When that is done, we will look into compatibility with Spring Boot 2.

[duke-cliff]

What's the roadmap for this? We are having the same issue few of reactive services are kind of blind right now.

[tylerbenson]

@duke-cliff @ctoestreich I recently implemented netty support in #352, which was just merged into master. We will be testing compatibility of that instrumentation with webflux over the next few weeks. If you'd like to try it out before hand, you can download the snapshot build and enable it by setting this system property at startup: -Ddd.integration.netty.enabled=true. If you do try that out, let me know if it works.
Thanks!

[ctoestreich]

I was able to verify that the the APM tracing is not working in a http://micronaut.io application that is based on netty. I am unable to find anywhere in this repo where the check the actually done for dd.integration.netty.enabled. Perhaps I missed it, but here is my app stack that isn't working.

https://github.com/tardisoft/micronaut-metrics-example

I will double check for spring boot 2 to see if that works.

[gihad]

@duke-cliff Can you please test the latest release of the java datadog agent on one of our Spring Webflux apps and one of our Vert.x apps? Please report your findings here and for @tylerbenson to see. Thank you.

[duke-cliff]

Okay will do

[tylerbenson]

It appears the netty instrumentation was broken in some cases. I believe this is resolved by a combination of #411 (released in 0.12.0) and #417 (which will be released in 0.13.0 -- you can find the snapshot build here).

We have tests (#434) that verify the netty instrumentation works for webflux on master, but are continuing to improve specific instrumentation for it.

This will still require -Ddd.integration.netty.enabled=true to enable it though.

Thanks for your patience and look forward to feedback.

[duke-cliff]

This is one more issue, I found the stack could not show our reactive redis calls. I have -Ddd.integration.lettuce.enabled=true in the arguments. @tylerbenson

[tylerbenson]

@duke-cliff @ctoestreich Additional Spring Webflux instrumentation has been added to our latest release: https://github.com/DataDog/dd-trace-java/releases/tag/v0.15.0