Comments (5)
The cirumstance where the 404s are not useful to be grouped together is because applications may implement generic routes with a different permission scheme. i.e. if I am seeing a huge number of 404s on the url pattern /foo/:id/bar/:id
, I want to see the spans with 404s grouped under the same resource name /foo/:id/bar/:id
instead of a catch-all 404
.
from dd-trace-java.
@rymndhng Is this instrumentation for a server? If so how would you know which resource to associate the 404 with?
For example, if you had two endpoints /my/service
and /other/service
, where would you expect a request /a/bad/request
to appear?
from dd-trace-java.
@realark I think I see where you're coming from. In the case where there is no tag resource.name
set, it would be valuable to set resource.name
to 404.
The current implementation always sets the resource.name
to 404 when the response status is 404. I think it would be more reasonable to set the resource.name
if it is not already set. This would users to distinguish between 404s from mismatched routes v.s. 404s returned by your application.
from dd-trace-java.
@rymndhng can you explain the circumstance where the 404 being returned by the application is useful to not group together?
from dd-trace-java.
Resolved with #1152
from dd-trace-java.
Related Issues (20)
- Trace agent fails to start on arm64 nodes HOT 9
- 'Failed to retrieve remote configuration' − please allow to disable remote configuration HOT 3
- Stream closed exception during Spring application startup HOT 2
- graphql java instrumentation impacting application throughput
- 🐞🐛 Serialization issue when IAST enabled with spring boot + kotlinx serialization HOT 5
- WARN `datadog.trace.agent.core.propagation.ptags.W3CPTagsCodec`: `Invalid datadog tags header value` HOT 4
- Adding datadog agent causes "java not found" error and fails to start HOT 3
- Baggage not being propagated in zio HOT 4
- JAR checksum of Maven artifact doesn't match GitHub release HOT 4
- Unified Service Tagging sometimes missing HOT 1
- Failed to inject helper classes HOT 3
- Memory Leak Issue with Datadog Integration in Kotlin/Ktor Application
- Add ability to provide custom normalization of URI mapping saved as resource name
- Cannot decode v0.4 traces payload: msgp: attempted to decode type "array" with method for "str" HOT 1
- feature request - instrumentation for https://github.com/http-kit/http-kit
- Trace id in logs are different from datadog trace id in web HOT 2
- dd-trace-java v1.31.2 crashes the JVM HOT 4
- RabbitMQ instrumentation tests is flaky HOT 1
- Spring Webflux 5 instrumentation tests are flaky
- Vert.X Redis client 4 instrumentation tests are flaky
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dd-trace-java.