Comments (4)
@jontonsoup we can add connect to the tracing (though often times thye happen outside the scope of a request). I don't see tracing adding 15 ms of setup overhead, but can work through it with you.
can you take a cProfile of your program startup?
from dd-trace-py.
@clutchski We already moved off dd-trace because the threading support just wasn't where we need it to be.
That said, the larger issue was that connecting to the DB took 15ms and dd-trace did not report this-- could have been latency or something else (we ended up fixing it by moving connect out of the hot path), but we would have never known if we didn't install new relic.
The issue is that the slowdown was in the datadog patch function itself. Just bringing up that this might be an issue you want to consider in the general case.
from dd-trace-py.
should be pretty simple, I recently added something similar to my aiohttp client tracing PR. If this gets added make sure to also add to aiopg + asyncpg contrib modules. Also note the complexity of time to connect, vs time to get connection from pool (may have to wait for connection from pool to become available).
from dd-trace-py.
The problem I see with tracing the connect
method is that it is most likely going to occur outside the context of a normal trace, meaning it'll be hard to correlate the effects of connect
on any given trace.
Closing this ticket for now due to it's age, please feel free to re-open if needed.
from dd-trace-py.
Related Issues (20)
- RuntimeWarnings in IPython when asyncio integration is active HOT 1
- ddtrace.patch breaks serializing loguru logger HOT 1
- DD Agent GlusterFS check returns python errors HOT 4
- DD_KAFKA_PROPAGATION_ENABLED detached traces HOT 4
- ddtrace 2.8.0 crashes with langchain HOT 2
- High CPU usage on startup HOT 13
- Unexpected TypeError while exporting events
- aiopg integration is broken HOT 2
- Datadog tracer SqlAlchemy integration exception
- ddtrace.readthedocs.io is stale HOT 4
- DDTraceDeprecationWarning: The 'span' keyword argument on ExecutionContext methods is deprecated HOT 1
- Set service name for boto3/botocore from env var HOT 1
- dd-trace auto-instrumentation not capturing error and stack trace details for HTTP Exception errors in FastAPI HOT 4
- Sample rate feature is not working (at all) HOT 1
- Asynchronous context manager crash with langchain-openai >= 0.1.2 HOT 3
- Upgrading from v2.4.0 to v2.8.1 changes tracking from `trace.django.request` to `trace.django.middleware` HOT 3
- ddtrace breaks Bedrock Cohere Command R models
- grpc integration causes exception with grpc.aio streaming HOT 1
- ModuleWatchdog is installed unconditionally when ddtrace is imported HOT 1
- Elastic Search Quantization not always effective and does not match Datadog agent's
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dd-trace-py.